dart/frog/leg/compile_time_constants.dart - Issue 9421025: Improve double implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/leg/compile_time_constants.dart

Issue 9421025: Improve double implementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/frog/leg/compile_time_constants.dart

diff --git a/dart/frog/leg/compile_time_constants.dart b/dart/frog/leg/compile_time_constants.dart

index 32234ad532b595ed6350fe4ea3eb4f728b7806c0..1cfc4d7a6fea8722d5dc001654eb6b171b6d33d8 100644

--- a/dart/frog/leg/compile_time_constants.dart

+++ b/dart/frog/leg/compile_time_constants.dart

@@ -161,10 +161,15 @@ class CompileTimeConstantHandler extends CompilerTask {

if (value === null) {

buffer.add("(void 0)");

} else if (value is num) {

- if (value.isNaN()) buffer.add("(0/0)");

- if (value == double.INFINITY) buffer.add("(1/0)");

- if (value == -double.INFINITY) buffer.add("(-1/0)");

- buffer.add("($value)");

+ if (value.isNaN()) {

+ buffer.add("(0/0)");

+ } else if (value == double.INFINITY) {

+ buffer.add("(1/0)");

+ } else if (value == -double.INFINITY) {

+ buffer.add("(-1/0)");

+ } else {

+ buffer.add("($value)");

+ }

} else if (value === true) {

buffer.add("true");

} else if (value === false) {

« no previous file with comments | « no previous file | dart/frog/leg/lib/js_helper.dart » ('j') | dart/frog/leg/lib/js_helper.dart » ('J')