Issue 9420050: Remove hand-written implementations of constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9420050: Remove hand-written implementations of constructors. (Closed)

Created:
8 years, 10 months ago by antonm

Modified:
8 years, 10 months ago

Reviewers:
podivilov

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

Remove hand-written implementations of constructors. One'd better say factories :) Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=181

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -72 lines)			Patch
D	Source/WebCore/bindings/dart/custom/DartFileReaderCustom.cpp	View	1 chunk	+0 lines, -64 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartXSLTProcessorCustom.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/WebCore/bindings/dart/gyp/overrides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

podivilov

8 years, 10 months ago (2012-02-17 17:49:36 UTC) #2

LGTM.

Thanks! Great to have all these constructors generated!