Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 9420049: Rename static methods to avoid shadowing virtual methods (Closed)

Created:
8 years, 10 months ago by ulan
Modified:
8 years, 10 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Rename static methods to avoid shadowing virtual methods and fix Clang C++11 compile error. Committed: https://code.google.com/p/v8/source/detail?r=10739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -82 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 14 chunks +74 lines, -80 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ulan
Please take a look.
8 years, 10 months ago (2012-02-17 12:47:30 UTC) #1
danno
8 years, 10 months ago (2012-02-17 12:56:19 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698