Chromium Code Reviews
Help | Chromium Project | Sign in
(915)

Issue 9420046: In gcmole assume that methods exiting VM can cause GC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by Vyacheslav Egorov
Modified:
2 years, 2 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

In gcmole assume that methods exiting VM can cause GC.

Detect those methods by reference to StateTag::EXTERNAL in their bodies.

R=fschneider@google.com

Committed: https://code.google.com/p/v8/source/detail?r=10738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Lint Patch
M tools/gcmole/gcmole.cc View 4 chunks +29 lines, -0 lines 0 comments 0 errors Download
M tools/gcmole/gcmole.lua View 2 chunks +7 lines, -2 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Vyacheslav Egorov
2 years, 2 months ago #1
fschneider
2 years, 2 months ago #2
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6