Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 9420045: After assignment return right hand side value instead of undefined when Object.isExtensible(o) === … (Closed)

Created:
8 years, 10 months ago by ioseb
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

After assignment return right hand side value instead of undefined when Object.isExtensible(o) === false Added corresponding tests ES5 description: http://es5.github.com/#x11.13.1 Related issue: http://code.google.com/p/v8/issues/detail?id=1901 Contributed by ioseb.dzmanashvili@gmail.com

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/object-prevent-extensions.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ioseb
After assignment return right hand side value instead of undefined when Object.isExtensible(o) === false Added ...
8 years, 10 months ago (2012-02-17 09:34:09 UTC) #1
rossberg
http://codereview.chromium.org/9420045/diff/1/test/mjsunit/object-prevent-extensions.js File test/mjsunit/object-prevent-extensions.js (right): http://codereview.chromium.org/9420045/diff/1/test/mjsunit/object-prevent-extensions.js#newcode124 test/mjsunit/object-prevent-extensions.js:124: assertEquals(50, v); Can you add a test for integer ...
8 years, 10 months ago (2012-02-17 12:39:35 UTC) #2
ioseb
Thank you very much for review! Done(added, tested, uploaded) see Patch Set2. On 2012/02/17 12:39:35, ...
8 years, 10 months ago (2012-02-17 12:59:33 UTC) #3
rossberg
lgtm
8 years, 10 months ago (2012-02-21 14:04:22 UTC) #4
rossberg
On 2012/02/21 14:04:22, rossberg wrote: > lgtm Landed as http://codereview.chromium.org/9429002/
8 years, 10 months ago (2012-02-21 14:10:25 UTC) #5
rossberg
Thanks for the patch!
8 years, 10 months ago (2012-02-21 14:13:46 UTC) #6
ioseb
8 years, 10 months ago (2012-02-21 14:17:49 UTC) #7
On 2012/02/21 14:13:46, rossberg wrote:
> Thanks for the patch!

You are welcome!

Powered by Google App Engine
This is Rietveld 408576698