After assignment return right hand side value instead of undefined when Object.isExtensible(o) === …

After assignment return right hand side value instead of undefined when Object.isExtensible(o) === false

Added corresponding tests

ES5 description: http://es5.github.com/#x11.13.1

Related issue: http://code.google.com/p/v8/issues/detail?id=1901

Contributed by ioseb.dzmanashvili@gmail.com

[ioseb, 2012-02-17 09:34:09]

After assignment return right hand side value instead of undefined when
Object.isExtensible(o) === false

Added corresponding tests

ES5 description: http://es5.github.com/#x11.13.1

Related issue: http://code.google.com/p/v8/issues/detail?id=1901

[rossberg, 2012-02-17 12:39:35]

http://codereview.chromium.org/9420045/diff/1/test/mjsunit/object-prevent-ext...
File test/mjsunit/object-prevent-extensions.js (right):

http://codereview.chromium.org/9420045/diff/1/test/mjsunit/object-prevent-ext...
test/mjsunit/object-prevent-extensions.js:124: assertEquals(50, v);
Can you add a test for integer properties, too? Because o[2] will take another
code path (fortunately, that already works).

[ioseb, 2012-02-17 12:59:33]

Thank you very much for review!

Done(added, tested, uploaded) see Patch Set2.

On 2012/02/17 12:39:35, rossberg wrote:
>
http://codereview.chromium.org/9420045/diff/1/test/mjsunit/object-prevent-ext...
> File test/mjsunit/object-prevent-extensions.js (right):
> 
>
http://codereview.chromium.org/9420045/diff/1/test/mjsunit/object-prevent-ext...
> test/mjsunit/object-prevent-extensions.js:124: assertEquals(50, v);
> Can you add a test for integer properties, too? Because o[2] will take another
> code path (fortunately, that already works).

[rossberg, 2012-02-21 14:04:22]

lgtm

[rossberg, 2012-02-21 14:10:25]

On 2012/02/21 14:04:22, rossberg wrote:
> lgtm

Landed as http://codereview.chromium.org/9429002/

[rossberg, 2012-02-21 14:13:46]

Thanks for the patch!

[ioseb, 2012-02-21 14:17:49]

On 2012/02/21 14:13:46, rossberg wrote:
> Thanks for the patch!

You are welcome!