Default parentId for bookmarks.create()

chrome/test/data/extensions/api_test/bookmarks/test.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

[Devlin, 2012/02/17 06:45:47]

Probably a good idea to update the copyright date.

[cduvall, 2012/02/17 07:01:35]

Done.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // bookmarks api test
 // browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks
 
 // This is global state that is maintained across tests as a reference
 // to compare against what's fetched from the browser (using compareTrees).
 // TODO(erikkay) It would be better if each test was self-contained and
 // didn't depend on global state.
@@ skipping 149 matching lines @@
     });
     chrome.bookmarks.create(node, pass(function(results) {
       node.id = results.id;  // since we couldn't know this going in
       node.index = 0;
       chrome.test.assertTrue(compareNode(node, results),
                              "created node != source");
       expected[0].children[0].children.push(node);
     }));
   },
 
+  function createNoParentId() {
+    var node = {title:"google", url:"http://www.google.com/"};
+    chrome.test.listenOnce(chrome.bookmarks.onCreated, function(id, created) {
+      node.id = created.id;
+      node.index = 0;
+      chrome.test.assertEq(id, node.id);
+      // Make sure parentId defaults to Other Bookmarks

[Devlin, 2012/02/17 06:45:47]

nit: comments should be grammatically correct (including punctuation).

[cduvall, 2012/02/17 07:01:35]

Done.

+      chrome.test.assertEq(expected[0].children[1].id, created.parentId);
+      chrome.test.assertTrue(compareNode(node, created));
+    });
+    chrome.bookmarks.create(node, pass(function(results) {
+      node.id = results.id;  // since we couldn't know this going in
+      node.index = 0;
+      chrome.test.assertTrue(compareNode(node, results),
+                             "created node != source");
+      expected[0].children[0].children.push(node);

[Devlin, 2012/02/17 06:45:47]

This seems like a lot of duplicate code....Is there a way we avoid this?

[cduvall, 2012/02/17 07:01:35]

The other tests (createInRoot(), create()) share almost all the same code, so I
wrote a similar test for consistency.

+    }));
+  },
+
   function createInRoot() {
     const error = "Can't modify the root bookmark folders.";
     var node = {parentId:"0", title:"g404", url:"http://www.google.com/404"};
     chrome.bookmarks.create(node, fail(error));
   },
 
   function createFolder() {
     var node = {parentId:"1", title:"foo bar"};  // folder
     chrome.test.listenOnce(chrome.bookmarks.onCreated, function(id, created) {
       node.id = created.id;
@@ skipping 285 matching lines @@
                            "Should only get the last 2 bookmarks");
 
       chrome.test.assertTrue(compareNode(node3, results[0]));
       chrome.test.assertTrue(compareNode(node2, results[1]));
     }));
   }
 ]);
 }
 
 run();