Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: runtime/lib/isolate.cc

Issue 9420038: Heartbeat implementation of dart:mirrors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/isolate.cc
===================================================================
--- runtime/lib/isolate.cc (revision 4295)
+++ runtime/lib/isolate.cc (working copy)
@@ -107,27 +107,6 @@
}
-// TODO(turnidge): Move to DartLibraryCalls.
-static RawObject* SendPortCreate(intptr_t port_id) {
- const String& class_name = String::Handle(String::NewSymbol("SendPortImpl"));
- const String& function_name = String::Handle(String::NewSymbol("_create"));
- const int kNumArguments = 1;
- const Array& kNoArgumentNames = Array::Handle();
- const Function& function = Function::Handle(
- Resolver::ResolveStatic(Library::Handle(Library::CoreLibrary()),
- class_name,
- function_name,
- kNumArguments,
- kNoArgumentNames,
- Resolver::kIsQualified));
- GrowableArray<const Object*> arguments(kNumArguments);
- arguments.Add(&Integer::Handle(Integer::New(port_id)));
- const Object& result = Object::Handle(
- DartEntry::InvokeStatic(function, arguments, kNoArgumentNames));
- return result.raw();
-}
-
-
static void RunIsolate(uword parameter) {
IsolateStartData* data = reinterpret_cast<IsolateStartData*>(parameter);
Isolate* isolate = data->isolate_;
@@ -337,7 +316,7 @@
// TODO(turnidge): Move this code up before we launch the new
// thread. That way we won't have a thread hanging around that we
// can't talk to.
- const Object& port = Object::Handle(SendPortCreate(port_id));
+ const Object& port = Object::Handle(DartLibraryCalls::NewSendPort(port_id));
if (port.IsError()) {
Exceptions::PropagateError(port);
}

Powered by Google App Engine
This is Rietveld 408576698