Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9420037: reuse the same browser when running webdriver tests (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: updated Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 6c0ddf60f46e679c55d1c063f1a80fffdcd0649a..d37bf2215f76f8c97423f85457d52a40d1c0e3eb 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -533,9 +533,10 @@ class StandardTestSuite implements TestSuite {
List<String> args;
if (component == 'webdriver') {
- args = ['$dartDir/tools/testing/run_selenium.py', '--out=$htmlPath',
+ args = ['$dartDir/tools/testing/run_selenium.py',
+ '--browser=${configuration["browser"]}',
Emily Fortuna 2012/02/21 18:19:35 Not that it really matters, but why did we change
Jennifer Messerly 2012/02/21 18:58:43 At one point I thought I needed --browser first so
Emily Fortuna 2012/02/21 19:35:33 Either way is fine. This works for me. I don't hav
'--timeout=${configuration["timeout"] - 2}',
- '--browser=${configuration["browser"]}'];
+ '--out=$htmlPath'];
} else {
args = [
'$dartDir/tools/testing/drt-trampoline.py',

Powered by Google App Engine
This is Rietveld 408576698