Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: frog/leg/ssa/builder.dart

Issue 9419050: Allow to invoke fields as if they were methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: update status files Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/leg/scanner/listener.dart ('k') | frog/tests/leg_only/src/Closure7Test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/ssa/builder.dart
diff --git a/frog/leg/ssa/builder.dart b/frog/leg/ssa/builder.dart
index 2f64229ae69dd48b0a175535aa5a243310778503..c74c887a0f4ef499225484b326e0b25dc78ff54e 100644
--- a/frog/leg/ssa/builder.dart
+++ b/frog/leg/ssa/builder.dart
@@ -1590,17 +1590,24 @@ class SsaBuilder implements Visitor {
if (element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
compiler.resolver.resolveMethodElement(element);
element = element.defaultImplementation;
- } else if (element.kind != ElementKind.FUNCTION) {
- compiler.unimplemented(
- "SsaBuilder.visitStaticSend static field invocation",
- node: node);
}
- HStatic target = new HStatic(element);
+ HInstruction target = new HStatic(element);
add(target);
var inputs = <HInstruction>[];
inputs.add(target);
- addStaticSendArgumentsToList(node, element, inputs);
- push(new HInvokeStatic(selector, inputs));
+ if (element.kind == ElementKind.FUNCTION ||
+ element.kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
+ addStaticSendArgumentsToList(node, element, inputs);
+ push(new HInvokeStatic(selector, inputs));
+ } else {
+ if (element.kind == ElementKind.GETTER) {
+ target = new HInvokeStatic(Selector.GETTER, inputs);
+ add(target);
+ inputs = <HInstruction>[target];
+ }
+ addDynamicSendArgumentsToList(node, inputs);
+ push(new HInvokeClosure(selector, inputs));
+ }
}
visitSend(Send node) {
« no previous file with comments | « frog/leg/scanner/listener.dart ('k') | frog/tests/leg_only/src/Closure7Test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698