net/spdy/spdy_network_transaction_unittest.cc - Issue 9419032: Modify the MockConnect constructor to take an enum of ASYNC or SYNC, instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 9419032: Modify the MockConnect constructor to take an enum of ASYNC or SYNC, instead (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Fix Test Break Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_proxy_client_socket_pool_unittest.cc ('K') | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_proxy_client_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/spdy/spdy_network_transaction_unittest.cc

===================================================================

--- net/spdy/spdy_network_transaction_unittest.cc (revision 122403)

+++ net/spdy/spdy_network_transaction_unittest.cc (working copy)

@@ -243,7 +243,7 @@

session_deps_->socket_factory->AddSSLSocketDataProvider(ssl_.get());

session_deps_->socket_factory->AddSocketDataProvider(data);

if (test_type_ == SPDYNPN) {

- MockConnect never_finishing_connect(false, ERR_IO_PENDING);

+ MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING);

linked_ptr<StaticSocketDataProvider>

hanging_non_alternate_protocol_socket(

new StaticSocketDataProvider(NULL, 0, NULL, 0));

@@ -273,7 +273,7 @@

}

session_deps_->deterministic_socket_factory->AddSocketDataProvider(data);

if (test_type_ == SPDYNPN) {

- MockConnect never_finishing_connect(false, ERR_IO_PENDING);

+ MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING);

scoped_refptr<DeterministicSocketData>

hanging_non_alternate_protocol_socket(

new DeterministicSocketData(NULL, 0, NULL, 0));

@@ -758,7 +758,7 @@

new OrderedSocketData(reads, arraysize(reads),

writes, arraysize(writes)));

- MockConnect never_finishing_connect(false, ERR_IO_PENDING);

+ MockConnect never_finishing_connect(SYNCHRONOUS, ERR_IO_PENDING);

scoped_ptr<OrderedSocketData> data_placeholder(

new OrderedSocketData(NULL, 0, NULL, 0));

@@ -845,7 +845,7 @@

new OrderedSocketData(reads, arraysize(reads),

writes, arraysize(writes)));

- MockConnect never_finishing_connect(true, ERR_IO_PENDING);

+ MockConnect never_finishing_connect(ASYNC, ERR_IO_PENDING);

scoped_ptr<OrderedSocketData> data_placeholder(

new OrderedSocketData(NULL, 0, NULL, 0));