Chromium Code Reviews Chromium Code Reviews
Issue 9419032:
Modify the MockConnect constructor to take an enum of ASYNC or SYNC, instead (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src/| Index: jingle/notifier/base/fake_ssl_client_socket_unittest.cc |
| =================================================================== |
| --- jingle/notifier/base/fake_ssl_client_socket_unittest.cc (revision 122403) |
| +++ jingle/notifier/base/fake_ssl_client_socket_unittest.cc (working copy) |
| @@ -131,7 +131,8 @@ |
| base::StringPiece ssl_server_hello = |
| FakeSSLClientSocket::GetSslServerHello(); |
| - net::MockConnect mock_connect(async, net::OK); |
| + net::MockConnect mock_connect(async ? net::ASYNC : net::SYNCHRONOUS, |
|
akalin
2012/02/17 19:46:49
ideally you'd propagate the enum up, but that's no
Ryan Hamilton
2012/02/17 19:58:09
Yup, I intend to do that in a subsequent CL, comin
|
| + net::OK); |
| std::vector<net::MockRead> reads; |
| std::vector<net::MockWrite> writes; |
| static const char kReadTestData[] = "read test data"; |
| @@ -192,7 +193,8 @@ |
| base::StringPiece ssl_server_hello = |
| FakeSSLClientSocket::GetSslServerHello(); |
| - net::MockConnect mock_connect(async, net::OK); |
| + net::MockConnect mock_connect(async ? net::ASYNC : net::SYNCHRONOUS, |
| + net::OK); |
| std::vector<net::MockRead> reads; |
| std::vector<net::MockWrite> writes; |
| const size_t kChunkSize = 1; |
