Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 9418014: Fix regression on prefix/suffix for libraries (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix error in previous change here: http://chromiumcodereview.appspot.com/9401016 Future change should use generator variables for prefix/suffix rather than duplicated copies. TBR=nico Committed: https://code.google.com/p/gyp/source/detail?r=1206

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pylib/gyp/generator/ninja.py View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
8 years, 10 months ago (2012-02-16 20:00:52 UTC) #1
scottmg
On 2012/02/16 20:00:52, scottmg wrote: Hmm, scratch that, it's a bit tricky. Here's the simple ...
8 years, 10 months ago (2012-02-16 20:01:46 UTC) #2
Nico
8 years, 10 months ago (2012-02-16 20:23:32 UTC) #3
patch set 2 lgtm

Powered by Google App Engine
This is Rietveld 408576698