Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/x64/assembler-x64.h

Issue 9418005: Ensure using byte registers for byte instructions on ia32 and x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 }; 124 };
125 return names[index]; 125 return names[index];
126 } 126 }
127 127
128 static Register from_code(int code) { 128 static Register from_code(int code) {
129 Register r = { code }; 129 Register r = { code };
130 return r; 130 return r;
131 } 131 }
132 bool is_valid() const { return 0 <= code_ && code_ < kNumRegisters; } 132 bool is_valid() const { return 0 <= code_ && code_ < kNumRegisters; }
133 bool is(Register reg) const { return code_ == reg.code_; } 133 bool is(Register reg) const { return code_ == reg.code_; }
134 // rax, rbx, rcx and rdx are byte registers, the rest are not.
135 bool is_byte_register() const { return code_ <= 3; }
134 int code() const { 136 int code() const {
135 ASSERT(is_valid()); 137 ASSERT(is_valid());
136 return code_; 138 return code_;
137 } 139 }
138 int bit() const { 140 int bit() const {
139 return 1 << code_; 141 return 1 << code_;
140 } 142 }
141 143
142 // Return the high bit of the register code as a 0 or 1. Used often 144 // Return the high bit of the register code as a 0 or 1. Used often
143 // when constructing the REX prefix byte. 145 // when constructing the REX prefix byte.
(...skipping 1500 matching lines...) Expand 10 before | Expand all | Expand 10 after
1644 private: 1646 private:
1645 Assembler* assembler_; 1647 Assembler* assembler_;
1646 #ifdef DEBUG 1648 #ifdef DEBUG
1647 int space_before_; 1649 int space_before_;
1648 #endif 1650 #endif
1649 }; 1651 };
1650 1652
1651 } } // namespace v8::internal 1653 } } // namespace v8::internal
1652 1654
1653 #endif // V8_X64_ASSEMBLER_X64_H_ 1655 #endif // V8_X64_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698