Moved access checks out of Dictionary class.

Moved access checks out of Dictionary class.

The checks were at the wrong abstraction level, JSObject is the right place for
this check. Note that other uses of ValueAtPut either don't need a check at all
(like the one used for copying boilerplate) or do the check for themselves.

Committed: https://code.google.com/p/v8/source/detail?r=10741

[Michael Starzinger, 2012-02-17 13:44:26]

LGTM (with a nit).

https://chromiumcodereview.appspot.com/9417044/diff/2001/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/9417044/diff/2001/src/objects.h#newcod...
src/objects.h:2913: return this->get(HashTable<Shape,
Key>::EntryToIndex(entry)+1);
I know you didn't touch this line, but could you add a space before and after
the plus operator here?

[Sven Panne, 2012-02-17 13:46:58]

https://chromiumcodereview.appspot.com/9417044/diff/2001/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/9417044/diff/2001/src/objects.h#newcod...
src/objects.h:2913: return this->get(HashTable<Shape,
Key>::EntryToIndex(entry)+1);
On 2012/02/17 13:44:26, Michael Starzinger wrote:
> I know you didn't touch this line, but could you add a space before and after
> the plus operator here?

Done.