dart/frog/leg/ssa/builder.dart - Issue 9417031: Mock up all remaining core library implementation classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/leg/ssa/builder.dart

Issue 9417031: Mock up all remaining core library implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/frog/leg/ssa/builder.dart

diff --git a/dart/frog/leg/ssa/builder.dart b/dart/frog/leg/ssa/builder.dart

index 192ead9bcd266177386e888ee165ae53c73ad0a3..8832f888e118151695f21cb6d57ba8b6d8e5a6ee 100644

--- a/dart/frog/leg/ssa/builder.dart

+++ b/dart/frog/leg/ssa/builder.dart

@@ -319,8 +319,7 @@ class LocalsHandler {

HInstruction readLocal(Element element) {

if (isAccessedDirectly(element)) {

if (directLocals[element] == null) {

- builder.compiler.internalError(

- "Could not find value", node: element.parseNode(builder.compiler));

+ builder.compiler.internalError("cannot find value", element: element);

}

return directLocals[element];

} else if (isStoredInClosureField(element)) {

« no previous file with comments | « dart/frog/leg/resolver.dart ('k') | dart/frog/leg/ssa/closure.dart » ('j') | no next file with comments »