Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: dart/frog/leg/frog_leg.dart

Issue 9417031: Mock up all remaining core library implementation classes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/frog/leg/lib/core.dart » ('j') | dart/frog/leg/lib/mockimpl.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/frog_leg.dart
diff --git a/dart/frog/leg/frog_leg.dart b/dart/frog/leg/frog_leg.dart
index 73a23d5221d7d1984891efe21028a1c26c78629e..874293ba051f4fbda4f9cd93c1440e052408b26a 100644
--- a/dart/frog/leg/frog_leg.dart
+++ b/dart/frog/leg/frog_leg.dart
@@ -108,6 +108,7 @@ class WorldCompiler extends Compiler {
print(script.file.getLocationMessage("cancel leg: $reason",
begin, end, true));
} else if (element !== null) {
+ if (element.position() === null) element = element.enclosingElement;
kasperl 2012/02/17 06:03:31 Maybe add a comment on when this happens? What kin
ahe 2012/02/17 07:40:47 I'm not sure this API is where I want it. For exam
ngeoffray 2012/02/17 10:03:50 The thing is, the backend should not cancel on ele
ahe 2012/02/17 16:26:46 Nicolas and I went back to the drawing board, and
withCurrentElement(element,
() => cancel(reason: reason, token: element.position()));
}
« no previous file with comments | « no previous file | dart/frog/leg/lib/core.dart » ('j') | dart/frog/leg/lib/mockimpl.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698