Mock up all remaining core library implementation classes.

dart/frog/leg/ssa/closure.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class ClosureFieldElement extends Element {
   ClosureFieldElement(SourceString name, ClassElement enclosing)
       : super(name, ElementKind.FIELD, enclosing);
 
   bool isInstanceMember() => true;
   bool isAssignable() => false;
@@ skipping 291 matching lines @@
         compiler.coreLibrary.find(const SourceString('Object'));
     globalizedElement.supertype = new SimpleType(Types.OBJECT, objectClass);
     // The nested function's 'this' is the same as the one for the outer
     // function. It could be [null] if we are inside a static method.
     Element thisElement = closureData.thisElement;
     return new ClosureData(element, globalizedElement,
                            callElement, thisElement);
   }
 
   visitFunctionExpression(FunctionExpression node) {
-    FunctionElement element = elements[node];
+    Element element = elements[node];
+    if (element.kind === ElementKind.PARAMETER) {
+      // TODO(ahe): This is a hack. This method should *not* call
+      // visitChildren.

[ngeoffray, 2012/02/17 10:03:50]

Please explain the hack: a parameter with a function type.

+      return node.name.accept(this);
+    }
     bool isClosure = (closureData !== null);
 
     if (isClosure) closures.add(node);
 
     bool oldInsideClosure = insideClosure;
     FunctionElement oldFunctionElement = currentFunctionElement;
     ClosureData oldClosureData = closureData;
     List<Element> oldScopeVariables = scopeVariables;
 
 
@@ skipping 30 matching lines @@
     if (!insideClosure && closureData.thisElement !== null) {
       declareLocal(closureData.thisElement);
     }
     // If we are inside a named closure we have to declare ourselve. For
     // simplicity we declare the local even if the closure does not have a name
     // It will simply not be used.
     if (insideClosure) {
       declareLocal(element);
     }
 
+    // TODO(ahe): This is problematic. The backend should not repeat
+    // the work of the resolver. It is the resolver's job to create
+    // parameters, etc. Other phases should only visit statements.

[ngeoffray, 2012/02/17 10:03:50]

Not sure I understand this comment, because the backend does not create
parameters.

[ahe, 2012/02/17 16:26:46]

The backend should run through "element.computeParameters(compiler)" instead of
calling visitChildren that will visit the very confusing parameter list.

     node.visitChildren(this);
 
     attachCapturedScopeVariables(node);
 
     closureDataCache[node] = closureData;
 
     ClosureData savedClosureData = closureData;
     bool savedInsideClosure = insideClosure;
 
     // Restore old values.
@@ skipping 14 matching lines @@
     }
   }
 
   visitTryStatement(TryStatement node) {
     // TODO(ngeoffray): implement finer grain state.
     inTryCatchOrFinally = true;
     node.visitChildren(this);
     inTryCatchOrFinally = false;
   }
 }