Chromium Code Reviews
Help | Chromium Project | Sign in
(124)

Issue 9417030: Enable cross-compilation with ninja. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by Ami GONE FROM CHROMIUM
Modified:
3 years ago
Reviewers:
Evan Martin
CC:
gyp-developer_googlegroups.com, piman (Very slow to review)
Base URL:
http://git.chromium.org/external/gyp.git@master
Visibility:
Public.

Description

Enable cross-compilation with ninja. Replaced the specialness of _host with _target, b/c the _host toolchain is usually the vanilla gcc/g++, so it looks better to leave those variables alone (plus, it mirrors make.py and GypPathToUniqueOutput). Added an AR to the family b/c it differs between host & target. Made generator_supports_multiple_toolsets depend on the presence of any of the $FOO_target variables as an intermediate hack around the double-building problem. BUG=gyp:213 Committed: https://code.google.com/p/gyp/source/detail?r=1231

Patch Set 1 #

Patch Set 2 : Default target tools to host tools #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M pylib/gyp/generator/ninja.py View 1 4 chunks +21 lines, -11 lines 1 comment Download
Trybot results:
Commit:

Messages

Total messages: 7 (0 generated)
Ami GONE FROM CHROMIUM
Evan: please review. Antoine: FYI. I replaced the specialness of _host with _target, b/c the ...
3 years ago (2012-02-16 23:43:26 UTC) #1
Evan Martin
On 2012/02/16 23:43:26, Ami Fischman wrote: > Evan: please review. > Antoine: FYI. > > ...
3 years ago (2012-02-16 23:48:32 UTC) #2
Ami GONE FROM CHROMIUM
On 2012/02/16 23:48:32, Evan Martin wrote: > Can you put some of these comments in ...
3 years ago (2012-02-16 23:53:02 UTC) #3
Ami GONE FROM CHROMIUM
Evan: ping?
3 years ago (2012-02-18 00:07:34 UTC) #4
Evan Martin
LGTM
3 years ago (2012-02-18 04:53:17 UTC) #5
Ami GONE FROM CHROMIUM
Evan: PTAL & land if LGTY. https://chromiumcodereview.appspot.com/9417030/diff/5001/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://chromiumcodereview.appspot.com/9417030/diff/5001/pylib/gyp/generator/ninja.py#newcode1075 pylib/gyp/generator/ninja.py:1075: master_ninja.variable('ar_target', os.environ.get('AR_target', '$ar')) ...
3 years ago (2012-02-22 22:18:54 UTC) #6
Evan Martin
3 years ago (2012-02-22 23:02:13 UTC) #7
r213
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87e6a26