Issue 9417025: icu: Warning tweaks in preparation for the next clang roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9417025: icu: Warning tweaks in preparation for the next clang roll. (Closed)

Created:
8 years, 10 months ago by Nico

Modified:
8 years, 10 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/

Visibility:
Public.

More Reviews

Description

icu: Warning tweaks in preparation for the next clang roll. BUG=chromium:84851, chromium:102390 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122379

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	icu.gyp	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

8 years, 10 months ago (2012-02-16 22:43:45 UTC) #2

LGTM

On Thu, Feb 16, 2012 at 2:43 PM,  <thakis@chromium.org> wrote:
> Reviewers: Evan Martin,
>
> Description:
> icu: Warning tweaks in preparation for the next clang roll.
>
> BUG=chromium:84851,chromium:102390
>
> Please review this at https://chromiumcodereview.appspot.com/9417025/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/
>
> Affected files:
>  M     icu.gyp
>
>
> Index: icu.gyp
> ===================================================================
> --- icu.gyp     (revision 122103)
> +++ icu.gyp     (working copy)
> @@ -333,6 +333,12 @@
>                   # the header should use U_NAMESPACE_BEGIN instead.
>                   # http://bugs.icu-project.org/trac/ticket/9054
>                   '-Wno-header-hygiene',
> +                  # ICU does some tricky array allocation that trips over
> +                  # -Warray-bounds. It seems to be harmless, see
> +                  # http://crbug.com/84851.
> +                  '-Wno-array-bounds',
> +                  # Looks like a real issue, see http://crbug.com/114660
> +                  '-Wno-return-type-c-linkage',
>                 ],
>               },
>               'cflags': [
> @@ -340,6 +346,8 @@
>                 '-Wno-logical-op-parentheses',
>                 '-Wno-tautological-compare',
>                 '-Wno-header-hygiene',
> +                '-Wno-array-bounds',
> +                '-Wno-return-type-c-linkage',
>               ],
>             }],
>           ],
>
>

Expand Messages | Collapse Messages