Issue 9416106: Add chrome common files to android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9416106: Add chrome common files to android build. (Closed)

Created:
8 years, 10 months ago by John Grabowski

Modified:
8 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add chrome common files to android build. Renaming two files from linux to posix to pull them into the android build, excluding them from the mac build to maintain status quo Taking over http://codereview.chromium.org/9414030/ from isaac due to presubmit issues. BUG=None TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123840

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -184 lines)			Patch
M	chrome/chrome_common.gypi	View	3 chunks	+6 lines, -2 lines	0 comments	Download
D	chrome/common/child_process_logging_linux.cc	View	1 chunk	+0 lines, -134 lines	0 comments	Download
A +	chrome/common/child_process_logging_posix.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/common/chrome_version_info_linux.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
A +	chrome/common/chrome_version_info_posix.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

John Grabowski

Transition from http://codereview.chromium.org/9414030 TBR=jam@chromium.org

8 years, 10 months ago (2012-02-22 21:13:48 UTC) #1

lgtm