Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9416097: Add butter bar to login screen to show device enrollement info. (Closed)

Created:
8 years, 10 months ago by Patrick Dubroy
Modified:
8 years, 9 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add butter bar to login screen to show device enrollement info. For now, the notification only shows the message "This device is managed by xyz.com." In the future, we will include a "Learn more" link, and a message about device status reporting if it is enabled. BUG=chromium-os:26625 TEST=Manual. Test that the butter bar appears on the login screen on a previously-enrolled device, and immediately after enrolling. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126912

Patch Set 1 #

Total comments: 16

Patch Set 2 : Move css into ChromeOS dir, and fix a typo. #

Patch Set 3 : Address nkostylev's comments. #

Total comments: 15

Patch Set 4 : Address comments #

Patch Set 5 : Update dates in copyright headers. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.h View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 2 3 1 chunk +12 lines, -1 line 0 comments Download
A chrome/browser/resources/chromeos/login/butter_bar.css View 1 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/display_manager.js View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 3 1 chunk +12 lines, -0 lines 3 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Patrick Dubroy
jhawkins: Can you take a look at butter_bar.css? I figured this might come in useful ...
8 years, 10 months ago (2012-02-22 14:28:06 UTC) #1
James Hawkins
On 2012/02/22 14:28:06, dubroy wrote: > jhawkins: Can you take a look at butter_bar.css? I ...
8 years, 10 months ago (2012-02-22 19:43:32 UTC) #2
James Hawkins
http://codereview.chromium.org/9416097/diff/1/chrome/browser/resources/shared/css/butter_bar.css File chrome/browser/resources/shared/css/butter_bar.css (right): http://codereview.chromium.org/9416097/diff/1/chrome/browser/resources/shared/css/butter_bar.css#newcode7 chrome/browser/resources/shared/css/butter_bar.css:7: /* A butter bar is an non-modal notification, usually ...
8 years, 10 months ago (2012-02-22 19:45:09 UTC) #3
Patrick Dubroy
http://codereview.chromium.org/9416097/diff/1/chrome/browser/resources/shared/css/butter_bar.css File chrome/browser/resources/shared/css/butter_bar.css (right): http://codereview.chromium.org/9416097/diff/1/chrome/browser/resources/shared/css/butter_bar.css#newcode7 chrome/browser/resources/shared/css/butter_bar.css:7: /* A butter bar is an non-modal notification, usually ...
8 years, 10 months ago (2012-02-23 14:55:43 UTC) #4
Nikita (slow)
http://codereview.chromium.org/9416097/diff/1/chrome/browser/chromeos/login/version_info_updater.cc File chrome/browser/chromeos/login/version_info_updater.cc (right): http://codereview.chromium.org/9416097/diff/1/chrome/browser/chromeos/login/version_info_updater.cc#newcode175 chrome/browser/chromeos/login/version_info_updater.cc:175: // message, which indicates that the message should not ...
8 years, 10 months ago (2012-02-23 14:58:50 UTC) #5
Patrick Dubroy
http://codereview.chromium.org/9416097/diff/1/chrome/browser/chromeos/login/version_info_updater.cc File chrome/browser/chromeos/login/version_info_updater.cc (right): http://codereview.chromium.org/9416097/diff/1/chrome/browser/chromeos/login/version_info_updater.cc#newcode175 chrome/browser/chromeos/login/version_info_updater.cc:175: // message, which indicates that the message should not ...
8 years, 9 months ago (2012-02-28 00:51:01 UTC) #6
Nikita (slow)
lgtm http://codereview.chromium.org/9416097/diff/1/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/9416097/diff/1/chrome/browser/resources/chromeos/login/oobe.css#newcode754 chrome/browser/resources/chromeos/login/oobe.css:754: #notification-area { On 2012/02/28 00:51:02, dubroy wrote: > ...
8 years, 9 months ago (2012-02-28 09:45:33 UTC) #7
James Hawkins
http://codereview.chromium.org/9416097/diff/12001/chrome/browser/chromeos/login/version_info_updater.cc File chrome/browser/chromeos/login/version_info_updater.cc (right): http://codereview.chromium.org/9416097/diff/12001/chrome/browser/chromeos/login/version_info_updater.cc#newcode164 chrome/browser/chromeos/login/version_info_updater.cc:164: const std::string& status_text) { nit: Fix parameter alignment. http://codereview.chromium.org/9416097/diff/12001/chrome/browser/resources/chromeos/login/display_manager.js ...
8 years, 9 months ago (2012-02-28 16:45:33 UTC) #8
Patrick Dubroy
http://codereview.chromium.org/9416097/diff/12001/chrome/browser/chromeos/login/version_info_updater.cc File chrome/browser/chromeos/login/version_info_updater.cc (right): http://codereview.chromium.org/9416097/diff/12001/chrome/browser/chromeos/login/version_info_updater.cc#newcode164 chrome/browser/chromeos/login/version_info_updater.cc:164: const std::string& status_text) { On 2012/02/28 16:45:33, James Hawkins ...
8 years, 9 months ago (2012-03-15 14:31:17 UTC) #9
James Hawkins
http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css#newcode755 chrome/browser/resources/chromeos/login/oobe.css:755: height: 0; height 0?
8 years, 9 months ago (2012-03-15 17:12:14 UTC) #10
Patrick Dubroy
http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css#newcode755 chrome/browser/resources/chromeos/login/oobe.css:755: height: 0; On 2012/03/15 17:12:14, James Hawkins wrote: > ...
8 years, 9 months ago (2012-03-15 17:16:30 UTC) #11
James Hawkins
http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css#newcode755 chrome/browser/resources/chromeos/login/oobe.css:755: height: 0; On 2012/03/15 17:16:31, dubroy wrote: > On ...
8 years, 9 months ago (2012-03-15 17:27:34 UTC) #12
Patrick Dubroy
On 2012/03/15 17:27:34, James Hawkins wrote: > http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css > File chrome/browser/resources/chromeos/login/oobe.css (right): > > http://codereview.chromium.org/9416097/diff/28004/chrome/browser/resources/chromeos/login/oobe.css#newcode755 ...
8 years, 9 months ago (2012-03-16 14:23:16 UTC) #13
James Hawkins
I'm going to be in China next week; not sure how much internet access I'll ...
8 years, 9 months ago (2012-03-18 02:56:47 UTC) #14
James Hawkins
On 2012/03/18 02:56:47, James Hawkins wrote: > I'm going to be in China next week; ...
8 years, 9 months ago (2012-03-18 02:57:41 UTC) #15
Patrick Dubroy
On 2012/03/18 02:57:41, James Hawkins wrote: > On 2012/03/18 02:56:47, James Hawkins wrote: > > ...
8 years, 9 months ago (2012-03-18 11:42:41 UTC) #16
jhawkins
8 years, 9 months ago (2012-03-19 00:25:16 UTC) #17 
New CL is fine; I was just confused about the situation.

Sent from my iPhone

On Mar 18, 2012, at 7:42 PM, "dubroy@chromium.org" <dubroy@chromium.org> wrote:

> On 2012/03/18 02:57:41, James Hawkins wrote:
>> On 2012/03/18 02:56:47, James Hawkins wrote:
>> > I'm going to be in China next week; not sure how much internet access I'll
>> have.
>> >  If I'm not around when you're ready for review, please pull in csilv to
>> finish
>> > the review.
>
>> This was committed already?
>
> Yes. Sorry, since I moved butter_bar.css under chromeos, I thought that LGTM
> from nkostylev was sufficient. I will fix this first thing Monday, or can
revert
> if you'd prefer.
>
> http://codereview.chromium.org/9416097/

Powered by Google App Engine
This is Rietveld 408576698