Issue 9416092: Eliminate use of ZONE macro in BitVector class and pass a zone explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9416092: Eliminate use of ZONE macro in BitVector class and pass a zone explicitly. (Closed)

Created:
8 years, 10 months ago by fschneider

Modified:
8 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Eliminate use of ZONE macro in BitVector class and pass a zone explicitly. Committed: https://code.google.com/p/v8/source/detail?r=10791

Patch Set 1 #

Total comments: 4

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -29 lines)			Patch
M	src/data-flow.h	View	1 chunk	+4 lines, -4 lines	1 comment	Download
M	src/hydrogen.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	src/lithium.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/lithium-allocator.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/lithium-allocator.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	test/cctest/test-dataflow.cc	View	6 chunks	+15 lines, -14 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 10 months ago (2012-02-22 11:36:06 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9416092/diff/1/src/data-flow.h
File src/data-flow.h (right):

https://chromiumcodereview.appspot.com/9416092/diff/1/src/data-flow.h#newcode1
src/data-flow.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

https://chromiumcodereview.appspot.com/9416092/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (right):

https://chromiumcodereview.appspot.com/9416092/diff/1/src/lithium-allocator.c...
src/lithium-allocator.cc:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

https://chromiumcodereview.appspot.com/9416092/diff/1/src/lithium-allocator.h
File src/lithium-allocator.h (right):

https://chromiumcodereview.appspot.com/9416092/diff/1/src/lithium-allocator.h...
src/lithium-allocator.h:1: // Copyright 2011 the V8 project authors. All rights
reserved.
nit: 2012

https://chromiumcodereview.appspot.com/9416092/diff/1/test/cctest/test-datafl...
File test/cctest/test-dataflow.cc (right):

https://chromiumcodereview.appspot.com/9416092/diff/1/test/cctest/test-datafl...
test/cctest/test-dataflow.cc:1: // Copyright 2010 the V8 project authors. All
rights reserved.
nit: 2012

Expand Messages | Collapse Messages