Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9416070: Move creation and ownership of HostZoomMap to content instead of having every embedder do this. (Closed)

Created:
8 years, 10 months ago by jam
Modified:
8 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move creation and ownership of HostZoomMap to content instead of having every embedder do this. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123002

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit + fix double delete with incognito #

Patch Set 3 : nit + fix double delete with incognito #

Patch Set 4 : fix mac/cros browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -157 lines) Patch
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 chunks +22 lines, -18 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 1 2 3 5 chunks +14 lines, -17 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 6 chunks +31 lines, -32 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/host_zoom_map_impl.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 1 2 3 4 chunks +13 lines, -5 lines 0 comments Download
M content/browser/host_zoom_map_impl_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/mock_resource_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/mock_resource_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/async_resource_handler.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/resource_context_impl.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 5 chunks +23 lines, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/browser_context.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/public/browser/host_zoom_map.h View 1 2 chunks +6 lines, -13 lines 0 comments Download
M content/public/browser/resource_context.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/shell/shell_browser_context.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/shell/shell_browser_context.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/shell/shell_resource_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_resource_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/test_browser_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_browser_context.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 10 months ago (2012-02-21 20:34:08 UTC) #1
Avi (use Gerrit)
lgtm https://chromiumcodereview.appspot.com/9416070/diff/1/chrome/browser/profiles/off_the_record_profile_impl.cc File chrome/browser/profiles/off_the_record_profile_impl.cc (right): https://chromiumcodereview.appspot.com/9416070/diff/1/chrome/browser/profiles/off_the_record_profile_impl.cc#newcode501 chrome/browser/profiles/off_the_record_profile_impl.cc:501: const content::NotificationDetails& details) { fix indent here
8 years, 10 months ago (2012-02-21 20:40:16 UTC) #2
jam
8 years, 10 months ago (2012-02-21 20:41:20 UTC) #3 
https://chromiumcodereview.appspot.com/9416070/diff/1/chrome/browser/profiles...
File chrome/browser/profiles/off_the_record_profile_impl.cc (right):

https://chromiumcodereview.appspot.com/9416070/diff/1/chrome/browser/profiles...
chrome/browser/profiles/off_the_record_profile_impl.cc:501: const
content::NotificationDetails& details) {
On 2012/02/21 20:40:16, Avi wrote:
> fix indent here

Done.

Powered by Google App Engine
This is Rietveld 408576698