src/objects-inl.h - Issue 9416058: Add missing checks for failure after AddElementsTransition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 9416058: Add missing checks for failure after AddElementsTransition. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

===================================================================

--- src/objects-inl.h (revision 10740)

+++ src/objects-inl.h (working copy)

@@ -3938,13 +3938,17 @@

Map* new_double_map = NULL;

if (!maybe_map->To<Map>(&new_double_map)) return maybe_map;

new_double_map->set_elements_kind(FAST_DOUBLE_ELEMENTS);

- initial_map->AddElementsTransition(FAST_DOUBLE_ELEMENTS, new_double_map);

+ maybe_map = initial_map->AddElementsTransition(FAST_DOUBLE_ELEMENTS,

+ new_double_map);

+ if (maybe_map->IsFailure()) return maybe_map;

maybe_map = new_double_map->CopyDropTransitions();

Map* new_object_map = NULL;

if (!maybe_map->To<Map>(&new_object_map)) return maybe_map;

new_object_map->set_elements_kind(FAST_ELEMENTS);

- new_double_map->AddElementsTransition(FAST_ELEMENTS, new_object_map);

+ maybe_map = new_double_map->AddElementsTransition(FAST_ELEMENTS,

+ new_object_map);

+ if (maybe_map->IsFailure()) return maybe_map;

global_context->set_smi_js_array_map(initial_map);

global_context->set_double_js_array_map(new_double_map);

« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »