Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: src/objects.h

Issue 9416058: Add missing checks for failure after AddElementsTransition. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4728 matching lines...) Expand 10 before | Expand all | Expand 10 after
4739 4739
4740 // Returns the map that this map transitions to if its elements_kind 4740 // Returns the map that this map transitions to if its elements_kind
4741 // is changed to |elements_kind|, or NULL if no such map is cached yet. 4741 // is changed to |elements_kind|, or NULL if no such map is cached yet.
4742 // |safe_to_add_transitions| is set to false if adding transitions is not 4742 // |safe_to_add_transitions| is set to false if adding transitions is not
4743 // allowed. 4743 // allowed.
4744 Map* LookupElementsTransitionMap(ElementsKind elements_kind, 4744 Map* LookupElementsTransitionMap(ElementsKind elements_kind,
4745 bool* safe_to_add_transition); 4745 bool* safe_to_add_transition);
4746 4746
4747 // Adds an entry to this map's descriptor array for a transition to 4747 // Adds an entry to this map's descriptor array for a transition to
4748 // |transitioned_map| when its elements_kind is changed to |elements_kind|. 4748 // |transitioned_map| when its elements_kind is changed to |elements_kind|.
4749 MaybeObject* AddElementsTransition(ElementsKind elements_kind, 4749 MUST_USE_RESULT MaybeObject* AddElementsTransition(
4750 Map* transitioned_map); 4750 ElementsKind elements_kind, Map* transitioned_map);
4751 4751
4752 // Returns the transitioned map for this map with the most generic 4752 // Returns the transitioned map for this map with the most generic
4753 // elements_kind that's found in |candidates|, or null handle if no match is 4753 // elements_kind that's found in |candidates|, or null handle if no match is
4754 // found at all. 4754 // found at all.
4755 Handle<Map> FindTransitionedMap(MapHandleList* candidates); 4755 Handle<Map> FindTransitionedMap(MapHandleList* candidates);
4756 Map* FindTransitionedMap(MapList* candidates); 4756 Map* FindTransitionedMap(MapList* candidates);
4757 4757
4758 4758
4759 // Dispatched behavior. 4759 // Dispatched behavior.
4760 #ifdef OBJECT_PRINT 4760 #ifdef OBJECT_PRINT
(...skipping 3538 matching lines...) Expand 10 before | Expand all | Expand 10 after
8299 } else { 8299 } else {
8300 value &= ~(1 << bit_position); 8300 value &= ~(1 << bit_position);
8301 } 8301 }
8302 return value; 8302 return value;
8303 } 8303 }
8304 }; 8304 };
8305 8305
8306 } } // namespace v8::internal 8306 } } // namespace v8::internal
8307 8307
8308 #endif // V8_OBJECTS_H_ 8308 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698