Issue 9416057: Merge r10739 into 3.6 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9416057: Merge r10739 into 3.6 branch. (Closed)

Created:
8 years, 10 months ago by ulan

Modified:
8 years, 10 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.6

Visibility:
Public.

More Reviews

Description

Merge r10739 into 3.6 branch. Rename static methods to avoid shadowing virtual methods and fix other compiler warnings.

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -69 lines)			Patch
M	src/elements.cc	View	12 chunks	+61 lines, -67 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ulan

Please take a look. Original CL https://chromiumcodereview.appspot.com/9420049/ Changes in elements.cc are strict subset of r10739 ...

8 years, 10 months ago (2012-02-17 13:45:59 UTC) #1

Yang

8 years, 10 months ago (2012-02-20 08:50:58 UTC) #2

On 2012/02/17 13:45:59, ulan wrote:
> Please take a look. 
> 
> Original CL https://chromiumcodereview.appspot.com/9420049/
> 
> Changes in elements.cc are strict subset of r10739 changes (The SetLength
method
> doesn't exist in 3.6).
> 
> Also I skipped the common.gypi change since there were conflicts and the
> -Woverloaded-virtual flag is not that important for 3.6.

LGTM if it compiles.

Expand Messages | Collapse Messages