Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: skia/ext/bitmap_platform_device_mac.cc

Issue 9416017: Optionally clear PlatformCanvas instances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/bitmap_platform_device_mac.cc
===================================================================
--- skia/ext/bitmap_platform_device_mac.cc (revision 126450)
+++ skia/ext/bitmap_platform_device_mac.cc (working copy)
@@ -125,11 +125,6 @@
bitmap.setPixels(data);
} else {
data = bitmap.getPixels();
-
- // Note: The Windows implementation clears the Bitmap later on.
- // This bears mentioning since removal of this line makes the
- // unit tests only fail periodically (or when MallocPreScribble is set).
- bitmap.eraseARGB(0, 0, 0, 0);
}
bitmap.setIsOpaque(is_opaque);
@@ -242,7 +237,10 @@
SkBitmap::Config config, int width, int height, bool isOpaque,
Usage /*usage*/) {
SkASSERT(config == SkBitmap::kARGB_8888_Config);
- return BitmapPlatformDevice::Create(NULL, width, height, isOpaque);
+ SkDevice* bitmap_device = BitmapPlatformDevice::Create(NULL, width, height,
+ isOpaque);
+ bitmap_device->accessBitmap(true).eraseARGB(0, 0, 0, 0);
+ return bitmap_device;
}
} // namespace skia
« no previous file with comments | « no previous file | skia/ext/bitmap_platform_device_mac_unittest.cc » ('j') | skia/ext/vector_platform_device_skia.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698