Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: chrome/app/app_mode-Info.plist

Issue 9416012: Mac: Generate App Mode Loader bundle + cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/app_mode_loader_mac.mm » ('j') | chrome/browser/web_applications/web_app_mac.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/app_mode-Info.plist
diff --git a/chrome/app/app_mode-Info.plist b/chrome/app/app_mode-Info.plist
index 611f7c56fb57d09891dee2060e4db15ca678dac8..1603382a11c826480cf79675d40bca2f7fb4e0f1 100644
--- a/chrome/app/app_mode-Info.plist
+++ b/chrome/app/app_mode-Info.plist
@@ -6,12 +6,14 @@
<string>en</string>
<key>CFBundleDisplayName</key>
<string>@APP_MODE_SHORTCUT_SHORT_NAME@</string>
+ <key>CFBundleSignature</key>
Mark Mentovai 2012/02/22 16:43:22 Do we need to include this at all? I’d prefer not
jeremy 2012/02/23 14:21:13 If I don't want to break the build with this CL th
+ <string>????</string>
<key>CFBundleExecutable</key>
- <string>@APP_MODE_SHORTCUT_ID@</string>
+ <string>${EXECUTABLE_NAME}</string>
<key>CFBundleIconFile</key>
<string>app.icns</string>
<key>CFBundleIdentifier</key>
- <string>????</string>
+ <string>${APP_MODE_APP_BUNDLE_ID}</string>
Mark Mentovai 2012/02/22 18:56:12 In the sample that you sent me, I see <ke
jeremy 2012/02/23 14:21:13 Done.
<key>CFBundleInfoDictionaryVersion</key>
<string>6.0</string>
<key>CFBundleName</key>
« no previous file with comments | « no previous file | chrome/app/app_mode_loader_mac.mm » ('j') | chrome/browser/web_applications/web_app_mac.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698