Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: chrome/app/chrome_main_app_mode_mac.mm

Issue 9416012: Mac: Generate App Mode Loader bundle + cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review comments Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // On Mac, one can't make shortcuts with command-line arguments. Instead, we 5 // On Mac, one can't make shortcuts with command-line arguments. Instead, we
6 // produce small app bundles which locate the Chromium framework and load it, 6 // produce small app bundles which locate the Chromium framework and load it,
7 // passing the appropriate data. This is the entry point into the framework for 7 // passing the appropriate data. This is the entry point into the framework for
8 // those app bundles. 8 // those app bundles.
9 9
10 #include <string> // TODO(viettrungluu): only needed for temporary hack 10 #include <string> // TODO(viettrungluu): only needed for temporary hack
11 11
12 #include "base/basictypes.h" 12 #include "base/basictypes.h"
13 #include "base/file_path.h" 13 #include "base/file_path.h"
14 #include "base/logging.h" 14 #include "base/logging.h"
15 #include "base/mac/bundle_locations.h"
16 #include "chrome/common/chrome_constants.h"
15 #include "chrome/common/chrome_paths_internal.h" 17 #include "chrome/common/chrome_paths_internal.h"
16 #include "chrome/common/mac/app_mode_common.h" 18 #include "chrome/common/mac/app_mode_common.h"
17 19
18 extern "C" { 20 extern "C" {
19 21
20 // |ChromeAppModeStart()| is the point of entry into the framework from the app 22 // |ChromeAppModeStart()| is the point of entry into the framework from the app
21 // mode loader. 23 // mode loader.
22 __attribute__((visibility("default"))) 24 __attribute__((visibility("default")))
23 int ChromeAppModeStart(const app_mode::ChromeAppModeInfo* info); 25 int ChromeAppModeStart(const app_mode::ChromeAppModeInfo* info);
24 26
(...skipping 10 matching lines...) Expand all
35 if (info->major_version > app_mode::kCurrentChromeAppModeInfoMajorVersion) { 37 if (info->major_version > app_mode::kCurrentChromeAppModeInfoMajorVersion) {
36 RAW_LOG(ERROR, "Browser Framework too old to load App Shortcut."); 38 RAW_LOG(ERROR, "Browser Framework too old to load App Shortcut.");
37 return 1; 39 return 1;
38 } 40 }
39 41
40 RAW_CHECK(!info->chrome_versioned_path.empty()); 42 RAW_CHECK(!info->chrome_versioned_path.empty());
41 FilePath* chrome_versioned_path = new FilePath(info->chrome_versioned_path); 43 FilePath* chrome_versioned_path = new FilePath(info->chrome_versioned_path);
42 RAW_CHECK(!chrome_versioned_path->empty()); 44 RAW_CHECK(!chrome_versioned_path->empty());
43 chrome::SetOverrideVersionedDirectory(chrome_versioned_path); 45 chrome::SetOverrideVersionedDirectory(chrome_versioned_path);
44 46
47 base::mac::SetOverrideOuterBundlePath(info->chrome_outer_bundle_path);
48 base::mac::SetOverrideFrameworkBundlePath(
49 chrome_versioned_path->Append(chrome::kFrameworkName));
50
45 // TODO(viettrungluu): do something intelligent with data 51 // TODO(viettrungluu): do something intelligent with data
46 // return ChromeMain(info->argc, info->argv); 52 // return ChromeMain(info->argc, info->argv);
47 // For now, a cheesy hack instead. 53 // For now, a cheesy hack instead.
48 RAW_CHECK(info->app_mode_url.size()); 54 RAW_CHECK(info->app_mode_url.size());
49 std::string argv1(std::string("--app=") + info->app_mode_url); 55 std::string argv1(std::string("--app=") + info->app_mode_url);
50 RAW_CHECK(info->app_mode_id.size()); 56 RAW_CHECK(info->app_mode_id.size());
51 std::string argv2(std::string("--user-data-dir=/tmp/") + info->app_mode_id); 57 std::string argv2(std::string("--user-data-dir=/tmp/") + info->app_mode_id);
52 char* argv[] = { info->argv[0], 58 char* argv[] = { info->argv[0],
53 const_cast<char*>(argv1.c_str()), 59 const_cast<char*>(argv1.c_str()),
54 const_cast<char*>(argv2.c_str()) }; 60 const_cast<char*>(argv2.c_str()) };
55 return ChromeMain(static_cast<int>(arraysize(argv)), argv); 61 return ChromeMain(static_cast<int>(arraysize(argv)), argv);
56 } 62 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698