Mac: Generate App Mode Loader bundle + cleanup

chrome/browser/web_applications/web_app_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
 #define CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_
 #pragma once
 
 #include "base/file_path.h"
+#include "base/string16.h"
 #include "chrome/browser/shell_integration.h"
 
+@class NSDictionary;

[Mark Mentovai, 2012/02/22 16:43:22]

This file looks like it could reasonably be #included by a C++ (not Objective-C)
file. We should take care to do:

#ifdef __OBJC__
@class NSDictionary;
@class NSString;
#else  // __OBJC__
class NSDictionary;
class NSString;
#endif  // __OBJC__

[jeremy, 2012/02/23 14:21:13]

Done.

+@class NSString;
+
 namespace web_app {
 
 // Creates a shortcut for a web application. The shortcut is a stub app
 // that simply loads the browser framework and runs the given app.
 class WebAppShortcutCreator {
  public:
   // Creates a new shortcut based on information in |shortcut_info|.
-  explicit WebAppShortcutCreator(
-      const ShellIntegration::ShortcutInfo& shortcut_info);
+  // |chrome_bundle_id| is the CFBundleIdentifier of the Chrome browser bundle.
+  WebAppShortcutCreator(
+      const ShellIntegration::ShortcutInfo& shortcut_info,
+      const string16& chrome_bundle_id);
   virtual ~WebAppShortcutCreator();
 
-  // Creates a shortcut.
+  // Copies the app launcher template into place and fills in all relevant
+  // information.
   bool CreateShortcut();
 
  protected:
   // Returns a path to the app loader.
   FilePath GetAppLoaderPath() const;
 
   // Returns a path to the destination where the app should be written to.
   virtual FilePath GetDestinationPath(const FilePath& app_file_name) const;
 
   // Updates the plist inside |app_path| with information about the app.
   bool UpdatePlist(const FilePath& app_path) const;
 
   // Updates the icon for the shortcut.
   bool UpdateIcon(const FilePath& app_path) const;
 
  private:
+  // Returns the bundle identifier to use for this app bundle.
+  // |plist| is a dictionary containg a copy of the template plist file to
+  // be used for creating the app bundle.
+  NSString* GetBundleIdentifier(NSDictionary* plist) const;
+
   // Information about the app.
   ShellIntegration::ShortcutInfo info_;
+
+  // The CFBundleIdentifier of the Chrome browser bundle.
+  string16 chrome_bundle_id_;
 };
 
 }  // namespace web_app
 
 #endif  // CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_MAC_H_