Issue 9415018: Revert 122320 - fake_dns tool for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9415018: Revert 122320 - fake_dns tool for Android. (Closed)

Created:
8 years, 10 months ago by Charlie Reis

Modified:
8 years, 10 months ago

Reviewers:
Xianzhu

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 122320 - fake_dns tool for Android. It runs on device to resolves any host name to 127.0.0.1. With it and the forwarder, all HTTP requests are redirected to our replay server running on the host machine. Review URL: http://codereview.chromium.org/9401014 TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122348

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -289 lines)			Patch
M	build/all_android.gyp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/android/common/adb_connection.cc	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	tools/android/common/net.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	tools/android/common/net.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
D	tools/android/fake_dns/fake_dns.cc	View	1 chunk	+0 lines, -222 lines	0 comments	Download
D	tools/android/fake_dns/fake_dns.gyp	View	1 chunk	+0 lines, -44 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Xianzhu

8 years, 10 months ago (2012-02-16 20:58:56 UTC) #2

On 2012/02/16 20:19:08, creis wrote:

My change is only for Android, so seems not related to the failure. Could you
re-submit the change when you make sure?

Expand Messages | Collapse Messages