Make built-ins strict mode conforming, and support a --use-strict flag.

src/collection.js

Index: src/collection.js
diff --git a/src/collection.js b/src/collection.js
index fcf4d38d94f80683d276db2efdc6b047cd0aac5e..75fe3d541db902ba539aada77fc601c7f5ae4821 100644
--- a/src/collection.js
+++ b/src/collection.js
@@ -25,10 +25,11 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+"use strict";

[Yang, 2012/02/17 08:22:55]

Some of the .js files have "use strict", some don't. Intentional?

[rossberg, 2012/02/17 09:20:17]

Yes. I spent the better part of my evening trying to get in "use strict"
everywhere, but lots of things went wrong: some tests failed that traverse the
.caller chain through higher-order library functions in array and string; the
debugger started executing all tests in strict mode (and thus failing), for
reasons that I didn't understand at all; and worst, with v8natives and runtime,
I even had weird crashes and assertion failures -- apparently, some of the
low-level code and primitive rely on sloppy semantics.

In the end, I just gave up and decided to keep everything sloppy by default,
except for new Harmony libs, and auxiliaries like message.js.

Long-term goal should be to get rid of it, but I leave that for future work.

 
-const $Set = global.Set;
-const $Map = global.Map;
-const $WeakMap = global.WeakMap;
+var $Set = global.Set;
+var $Map = global.Map;
+var $WeakMap = global.WeakMap;
 
 //-------------------------------------------------------------------