[Sync] Switch Extension Settings DTC to use ProfilesyncComponentsFactory

chrome/browser/extensions/settings/settings_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/settings/settings_frontend.h"
@@ skipping 51 matching lines @@
 
   void FinalReplyWhenSatisfied(
       Namespace settings_namespace,
       const std::string& normal_action,
       const std::string& incognito_action) {
     MaybeLoadAndReplyWhenSatisfied(
         settings_namespace, normal_action, incognito_action, NULL, true);
   }
 
   void InitSync(SyncChangeProcessor* sync_processor) {
-    browser()->profile()->GetExtensionService()->
-        settings_frontend()->RunWithSyncableService(
+    content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
+        base::Bind(
+            &ExtensionSettingsApiTest::InitSyncWithSyncableService,
+            this,
+            sync_processor,
             // TODO(kalman): test both EXTENSION_SETTINGS and APP_SETTINGS.
-            syncable::EXTENSION_SETTINGS,
-            base::Bind(
-                &ExtensionSettingsApiTest::InitSyncWithSyncableService,
-                this,
-                sync_processor));
+            browser()->profile()->GetExtensionService()->settings_frontend()->
+                GetBackendForSync(syncable::EXTENSION_SETTINGS)));

[not at google - send to devlin, 2012/02/16 22:58:44]

These tests all run on a single thread with the required message loops, so the
PostTasking should be unnecessary now; just

InitSyncWithSyncableService(
    sync_processor,
    b()->p()->gES()->s_f()->GetBackendForSync(s::E_S));

and hopefully no need for the MessageLoop:: stuff. Same below.

[Nicolas Zea, 2012/02/23 00:27:58]

Done.

[not at google - send to devlin, 2012/02/23 02:15:38]

.. so you do still need the MessageLoop stuff then? It just got moved above the
block.

[Nicolas Zea, 2012/02/24 21:38:04]

Yes, there's apparently other parts of the code that post tasks, and they need
to have run before this (was getting crashes otherwise).

     MessageLoop::current()->RunAllPending();
   }
 
   void SendChanges(const SyncChangeList& change_list) {
-    browser()->profile()->GetExtensionService()->
-        settings_frontend()->RunWithSyncableService(
+    content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
+        base::Bind(
+            &ExtensionSettingsApiTest::SendChangesToSyncableService,
+            this,
+            change_list,
             // TODO(kalman): test both EXTENSION_SETTINGS and APP_SETTINGS.
-            syncable::EXTENSION_SETTINGS,
-            base::Bind(
-                &ExtensionSettingsApiTest::SendChangesToSyncableService,
-                this,
-                change_list));
+            browser()->profile()->GetExtensionService()->settings_frontend()->
+                GetBackendForSync(syncable::EXTENSION_SETTINGS)));
     MessageLoop::current()->RunAllPending();
   }
 
  private:
   const Extension* MaybeLoadAndReplyWhenSatisfied(
       Namespace settings_namespace,
       const std::string& normal_action,
       const std::string& incognito_action,
       // May be NULL to imply not loading the extension.
       const std::string* extension_dir,
@@ skipping 248 matching lines @@
   SendChanges(sync_changes);
 
   FinalReplyWhenSatisfied(LOCAL,
       "assertNoNotifications", "assertNoNotifications");
 
   EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
   EXPECT_TRUE(catcher_incognito.GetNextResult()) << catcher.message();
 }
 
 }  // namespace extensions