Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 9414019: make: drop all system tests (Closed)

Created:
8 years, 10 months ago by Evan Martin
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make: drop all system tests Rather than probing for ARFLAGS at gyp type, just always use "crs". This will change systems that use thin archives to start using "fat" archives. A subsequent change will allow the outer project to control this setting. BUG=gyp:250 Committed: https://code.google.com/p/gyp/source/detail?r=1208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -112 lines) Patch
M pylib/gyp/generator/make.py View 7 chunks +2 lines, -43 lines 0 comments Download
M pylib/gyp/generator/ninja.py View 1 chunk +0 lines, -1 line 0 comments Download
D pylib/gyp/system_test.py View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Martin
8 years, 10 months ago (2012-02-16 19:51:24 UTC) #1
Nico
Hm, we try to keep gyp rollable at all times…can you land the subsequent change ...
8 years, 10 months ago (2012-02-16 20:22:00 UTC) #2
Nico
patch set 2 lgtm
8 years, 10 months ago (2012-02-16 20:22:59 UTC) #3
Nico
sorry, wrong review url :-/ For this CL, my first comment stands.
8 years, 10 months ago (2012-02-16 20:23:19 UTC) #4
Evan Martin
On 2012/02/16 20:23:19, Nico wrote: > sorry, wrong review url :-/ > > For this ...
8 years, 10 months ago (2012-02-16 20:26:12 UTC) #5
Nico
On 2012/02/16 20:26:12, Evan Martin wrote: > On 2012/02/16 20:23:19, Nico wrote: > > sorry, ...
8 years, 10 months ago (2012-02-16 20:32:28 UTC) #6
Nico
8 years, 10 months ago (2012-02-16 20:32:31 UTC) #7
Evan Martin
On 2012/02/16 20:32:28, Nico wrote: > On 2012/02/16 20:26:12, Evan Martin wrote: > > On ...
8 years, 10 months ago (2012-02-16 20:36:16 UTC) #8
Nico
8 years, 10 months ago (2012-02-16 20:37:21 UTC) #9
> A few seconds.  The files are all still hot.  It mostly helps for incremental
> builds and low-memory situations.

If you think it's bearable, I guess it's ok :-)

LGTM

Powered by Google App Engine
This is Rietveld 408576698