Initial implementation of a flow-graph builder for Dart's AST.

runtime/vm/code_generator_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/code_generator.h"
 
 #include "lib/error.h"
 #include "vm/ast_printer.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
+#include "vm/flow_graph_builder.h"
 #include "vm/ic_data.h"
 #include "vm/longjump.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/resolver.h"
 #include "vm/stub_code.h"
 
 namespace dart {
 
@@ skipping 170 matching lines @@
 
 
 bool CodeGenerator::IsResultNeeded(AstNode* node) const {
   return !state()->IsRootNode(node);
 }
 
 
 // NOTE: First 5 bytes of the code may be patched with a jump instruction. Do
 // not emit any objects in the first 5 bytes.
 void CodeGenerator::GenerateCode() {
+  FlowGraphBuilder graph_builder(parsed_function());
+  graph_builder.BuildGraph();

[srdjan, 2012/02/16 14:14:34]

You want to decouple FlowGraphBuilder from old compiler/codegenerator. I suggest
moving it to compiler.cc, function CompileFunctionHelper and use a flag to turn
it on/off.

[Kevin Millikin (Google), 2012/02/20 14:50:19]

Done.

+
   CodeGeneratorState codegen_state(this);
   if (FLAG_print_scopes && FLAG_print_ast) {
     // Print the function scope before code generation.
     AstPrinter::PrintFunctionScope(parsed_function_);
   }
   if (FLAG_print_ast) {
     // Print the function ast before code generation.
     AstPrinter::PrintFunctionNodes(parsed_function_);
   }
   if (FLAG_trace_functions) {
@@ skipping 2593 matching lines @@
   const Error& error = Error::Handle(
       Parser::FormatError(script, token_index, "Error", format, args));
   va_end(args);
   Isolate::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32