Throw NoSuchMethod or IllegalArgument on bad operators or bad arguments to

frog/corejs.dart

Index: frog/corejs.dart
diff --git a/frog/corejs.dart b/frog/corejs.dart
index 111edb6527079b24e5e120c8c88e2e123af7d180..3449d59d35137abdbb708529410bbd5efca9b67c 100644
--- a/frog/corejs.dart
+++ b/frog/corejs.dart
@@ -44,6 +44,15 @@ class CoreJs {
   void useOperator(String name) {
     if (_usedOperators[name] != null) return;
 
+    if (name != ':ne' && name != ':eq') {
+      // TODO(jimhug): Only do this once!
+      world.gen.markTypeUsed(world.corelib.types['NoSuchMethodException']);

[kasperl, 2012/02/15 11:54:49]

How about adding a helper for this statement?

[floitsch, 2012/02/15 13:11:43]

Done.

+    }
+    if (name != ':bit_not' && name != ':negate') {
+        // TODO(jimhug): Only do this once!
+      world.gen.markTypeUsed(world.corelib.types['IllegalArgumentException']);
+    }
+
     var code;
     switch (name) {
       case ':ne':
@@ -145,12 +154,14 @@ class CoreJs {
     }
 
     if (useIndex) {
+      world.gen.markTypeUsed(world.corelib.types['NoSuchMethodException']);
       ensureDefProp();
       w.writeln(options.disableBoundsChecks ?
         _INDEX_OPERATORS : _CHECKED_INDEX_OPERATORS);
     }
 
     if (useSetIndex) {
+      world.gen.markTypeUsed(world.corelib.types['NoSuchMethodException']);
       ensureDefProp();
       w.writeln(options.disableBoundsChecks ?
         _SETINDEX_OPERATORS : _CHECKED_SETINDEX_OPERATORS);
@@ -195,20 +206,14 @@ class CoreJs {
 final String _NE_FUNCTION = @"""
 function $ne(x, y) {
   if (x == null) return y != null;
-  return (typeof(x) == 'number' && typeof(y) == 'number') ||
-         (typeof(x) == 'boolean' && typeof(y) == 'boolean') ||
-         (typeof(x) == 'string' && typeof(y) == 'string')
-    ? x != y : !x.$eq(y);
+  return (typeof(x) != 'object') ? x !== y : !x.$eq(y);

[kasperl, 2012/02/15 11:54:49]

This changes things for functions, right? I guess that's intentional?

[floitsch, 2012/02/15 13:11:43]

AFAICS functions don't override the $eq method and would use the one on
Object.prototype which does ===. So everything stays the same.

 }""";
 
 /** Snippet for `$eq`. */
 final String _EQ_FUNCTION = @"""
 function $eq(x, y) {
   if (x == null) return y == null;
-  return (typeof(x) == 'number' && typeof(y) == 'number') ||
-         (typeof(x) == 'boolean' && typeof(y) == 'boolean') ||
-         (typeof(x) == 'string' && typeof(y) == 'string')
-    ? x == y : x.$eq(y);
+  return (typeof(x) != 'object') ? x === y : x.$eq(y);
 }
 // TODO(jimhug): Should this or should it not match equals?
 $defProp(Object.prototype, '$eq', function(other) {
@@ -218,61 +223,98 @@ $defProp(Object.prototype, '$eq', function(other) {
 /** Snippet for `$bit_not`. */
 final String _BIT_NOT_FUNCTION = @"""
 function $bit_not(x) {
-  return (typeof(x) == 'number') ? ~x : x.$bit_not();
+  if (typeof(x) == 'number') return ~x;
+  if (typeof(x) == 'object') return  x.$bit_not();
+  $throw(new NoSuchMethodException(x, "operator ~", []));
 }""";
 
 /** Snippet for `$negate`. */
 final String _NEGATE_FUNCTION = @"""
 function $negate(x) {
-  return (typeof(x) == 'number') ? -x : x.$negate();
+  if (typeof(x) == 'number') return -x;
+  if (typeof(x) == 'object') return x.$negate();
+  $throw(new NoSuchMethodException(x, "operator negate", []));
 }""";
 
 /** Snippet for `$add`. This relies on JS's string "+" to match Dart's. */
 final String _ADD_FUNCTION = @"""
 function $add(x, y) {
-  return ((typeof(x) == 'number' && typeof(y) == 'number') ||
-          (typeof(x) == 'string'))
-    ? x + y : x.$add(y);
+  if (typeof(x) == 'number') {

[kasperl, 2012/02/15 11:54:49]

It's hard to understand what this does for performance. Would it be possible to
only cover the number case in this method and call some other method
$add$complex for the other cases so the simple case can be inlined without
dragging everything in? This might make sense for the generic _otherOperator
too.

[floitsch, 2012/02/15 13:11:43]

Done.

+    if (typeof(y) == 'number') return x + y;
+    $throw(new IllegalArgumentException(y));
+  } else if (typeof(x) == 'string') {
+    var str = (y == null) ? 'null' : y.toString();
+    if (typeof(str) != 'string') {
+      throw new Error("calling toString() on right hand operand of operator " +
+                      "+ did not return a String");
+    }
+    return x + str;
+  } else if (typeof(x) == 'object') {
+    return x.$add(y);
+  } else {
+    $throw(new NoSuchMethodException(x, "operator +", [y]));
+  }
 }""";
 
 /** Snippet for `$truncdiv`. This uses `$throw`. */
 final String _TRUNCDIV_FUNCTION = @"""
 function $truncdiv(x, y) {
-  if (typeof(x) == 'number' && typeof(y) == 'number') {
-    if (y == 0) $throw(new IntegerDivisionByZeroException());
-    var tmp = x / y;
-    return (tmp < 0) ? Math.ceil(tmp) : Math.floor(tmp);
-  } else {
+  if (typeof(x) == 'number') {
+    if  (typeof(y) == 'number') {

[kasperl, 2012/02/15 11:54:49]

if  ( -> if (

[floitsch, 2012/02/15 13:11:43]

Done.

+      if (y == 0) $throw(new IntegerDivisionByZeroException());
+      var tmp = x / y;
+      return (tmp < 0) ? Math.ceil(tmp) : Math.floor(tmp);
+    } else {
+      $throw(new IllegalArgumentException(y));
+    }
+  } else if (typeof(x) == 'object') {
     return x.$truncdiv(y);
+  } else {
+    $throw(new NoSuchMethodException(x, "operator ~/", [y]));
   }
 }""";
 
 /** Snippet for `$mod`. */
 final String _MOD_FUNCTION = @"""
 function $mod(x, y) {
-  if (typeof(x) == 'number' && typeof(y) == 'number') {
-    var result = x % y;
-    if (result == 0) {
-      return 0;  // Make sure we don't return -0.0.
-    } else if (result < 0) {
-      if (y < 0) {
-        return result - y;
-      } else {
-        return result + y;
+  if (typeof(x) == 'number') {
+    if (typeof(y) == 'number') {
+      var result = x % y;
+      if (result == 0) {
+        return 0;  // Make sure we don't return -0.0.
+      } else if (result < 0) {
+        if (y < 0) {
+          return result - y;
+        } else {
+          return result + y;
+        }
       }
+      return result;
+    } else {
+      $throw(new IllegalArgumentException(y));
     }
-    return result;
-  } else {
+  } else if (typeof(x) == 'object') {
     return x.$mod(y);
-  }
+  } else {
+    $throw(new NoSuchMethodException(x, "operator %", [y]));
+  }h
 }""";
 
 /** Code snippet for all other operators. */
 String _otherOperator(String jsname, String op) {
   return """
 function $jsname(x, y) {
-  return (typeof(x) == 'number' && typeof(y) == 'number')
-    ? x $op y : x.$jsname(y);
+  if (typeof(x) == 'number') {
+    if (typeof(y) == 'number') {
+      return x $op y;
+    } else {
+      \$throw(new IllegalArgumentException(y));
+    }
+  } else if (typeof(x) == 'object') {
+    return x.$jsname(y);
+  } else {
+    \$throw(new NoSuchMethodException(x, "operator $op", [y]));
+  }
 }""";
 }
 
@@ -423,11 +465,7 @@ function $throw(e) {
 // like a normal method.
 final String _INDEX_OPERATORS = @"""
 $defProp(Object.prototype, '$index', function(i) {
-  var proto = Object.getPrototypeOf(this);
-  if (proto !== Object) {
-    proto.$index = function(i) { return this[i]; }
-  }
-  return this[i];
+  $throw(new NoSuchMethodException(this, "operator []", [i]));
 });
 $defProp(Array.prototype, '$index', function(i) { 
   return this[i]; 
@@ -438,11 +476,7 @@ $defProp(String.prototype, '$index', function(i) {
 
 final String _CHECKED_INDEX_OPERATORS = @"""
 $defProp(Object.prototype, '$index', function(i) {
-  var proto = Object.getPrototypeOf(this);
-  if (proto !== Object) {
-    proto.$index = function(i) { return this[i]; }
-  }
-  return this[i];
+  $throw(new NoSuchMethodException(this, "operator []", [i]));
 });
 $defProp(Array.prototype, '$index', function(index) {
   var i = index | 0;
@@ -462,22 +496,14 @@ $defProp(String.prototype, '$index', function(i) {
 /** Snippet for `$setindex` in Object, Array, and String. */
 final String _SETINDEX_OPERATORS = @"""
 $defProp(Object.prototype, '$setindex', function(i, value) {
-  var proto = Object.getPrototypeOf(this);
-  if (proto !== Object) {
-    proto.$setindex = function(i, value) { return this[i] = value; }
-  }
-  return this[i] = value;
+  $throw(new NoSuchMethodException(this, "operator []=", [i, value]));
 });
 $defProp(Array.prototype, '$setindex',
     function(i, value) { return this[i] = value; });""";
 
 final String _CHECKED_SETINDEX_OPERATORS = @"""
 $defProp(Object.prototype, '$setindex', function(i, value) {
-  var proto = Object.getPrototypeOf(this);
-  if (proto !== Object) {
-    proto.$setindex = function(i, value) { return this[i] = value; }
-  }
-  return this[i] = value;
+  $throw(new NoSuchMethodException(this, "operator []=", [i, value]));
 });
 $defProp(Array.prototype, '$setindex', function(index, value) {
   var i = index | 0;