Issue 9407030: mac: Let `mac-tool flock` exit with the exit code of the child program.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9407030: mac: Let `mac-tool flock` exit with the exit code of the child program. (Closed)

Created:
8 years, 10 months ago by Nico

Modified:
8 years, 10 months ago

Reviewers:
Robert Sesek, Evan Martin

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

mac: Let `mac-tool flock` exit with the exit code of the child program. TEST=When a link fails in the mac/ninja build, postbuilds no longer try to run. Committed: https://code.google.com/p/gyp/source/detail?r=1204

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	pylib/gyp/mac_tool.py	View		2 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

First reviewer wins. https://chromiumcodereview.appspot.com/9407030/diff/1/pylib/gyp/mac_tool.py File pylib/gyp/mac_tool.py (right): https://chromiumcodereview.appspot.com/9407030/diff/1/pylib/gyp/mac_tool.py#newcode38 pylib/gyp/mac_tool.py:38: return getattr(self, method)(*args[1:]) ExecFlock() below does ...

8 years, 10 months ago (2012-02-16 02:13:46 UTC) #1

lgtm

Expand Messages | Collapse Messages