Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: build/download_nacl_toolchains.py

Issue 9407015: Revert 122113 - Fix pnacl SDK builder (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/buildbot_run.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Shim to run nacl toolchain download script only if there is a nacl dir.""" 6 """Shim to run nacl toolchain download script only if there is a nacl dir."""
7 7
8 import os 8 import os
9 import sys 9 import sys
10 10
(...skipping 16 matching lines...) Expand all
27 import download_toolchains 27 import download_toolchains
28 28
29 # TODO (robertm): Finish getting PNaCl ready for prime time. 29 # TODO (robertm): Finish getting PNaCl ready for prime time.
30 # BUG: 30 # BUG:
31 # We remove this --optional-pnacl argument, and instead replace it with 31 # We remove this --optional-pnacl argument, and instead replace it with
32 # --no-pnacl for most cases. However, if the bot name is the pnacl_sdk 32 # --no-pnacl for most cases. However, if the bot name is the pnacl_sdk
33 # bot then we will go ahead and download it. This prevents increasing the 33 # bot then we will go ahead and download it. This prevents increasing the
34 # gclient sync time for developers, or standard Chrome bots. 34 # gclient sync time for developers, or standard Chrome bots.
35 if '--optional-pnacl' in args: 35 if '--optional-pnacl' in args:
36 args.remove('--optional-pnacl') 36 args.remove('--optional-pnacl')
37 buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '') 37 if os.environ.get('BUILDBOT_BUILDERNAME', '') == 'linux_pnacl_sdk':
38 if buildbot_name.contains('pnacl') and buildbot_name.contains('sdk'):
39 print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n' 38 print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
40 else: 39 else:
41 args.append('--no-pnacl') 40 args.append('--no-pnacl')
42 41
43 download_toolchains.Main(args) 42 download_toolchains.Main(args)
44 return 0 43 return 0
45 44
46 45
47 if __name__ == '__main__': 46 if __name__ == '__main__':
48 sys.exit(Main(sys.argv[1:])) 47 sys.exit(Main(sys.argv[1:]))
49 48
OLDNEW
« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/buildbot_run.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698