sandbox/linux/bpf_dsl/trap_registry.h - Issue 940693004: bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/bpf_dsl/trap_registry.h

Issue 940693004: bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to jln feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/linux/bpf_dsl/trap_registry.h

diff --git a/sandbox/linux/bpf_dsl/trap_registry.h b/sandbox/linux/bpf_dsl/trap_registry.h

index 94d4722c8cc359dce0574f0982279b0d1e5d58db..6f8d37a7f48842ffe1ac0778ef1f56e1caaa42d1 100644

--- a/sandbox/linux/bpf_dsl/trap_registry.h

+++ b/sandbox/linux/bpf_dsl/trap_registry.h

@@ -53,6 +53,10 @@ class SANDBOX_EXPORT TrapRegistry {

protected:

TrapRegistry() {}

+ // TrapRegistry's destructor is intentionally non-virtual so that

+ // implementations can omit their destructor. Instead we protect against

+ // misuse by marking it protected.

~TrapRegistry() {}

DISALLOW_COPY_AND_ASSIGN(TrapRegistry);

« no previous file with comments | « sandbox/linux/bpf_dsl/seccomp_macros.h ('k') | sandbox/linux/seccomp-bpf/trap.h » ('j') | no next file with comments »