Makes it so the launcher only gets focus when using the keyboard.

Makes it so the launcher only gets focus when using the keyboard.

BUG=114502
TEST=see bug
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=122459

[Ben Goodger (Google), 2012-02-16 02:57:43]

http://codereview.chromium.org/9406031/diff/1/ui/views/widget/native_widget_a...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/9406031/diff/1/ui/views/widget/native_widget_a...
ui/views/widget/native_widget_aura.cc:768: return can_activate_ &&
delegate_->CanActivate();
I don't think this can work... did you test this?

delegate_ is the Widget. You want the delegate_'s delegate... i.e. the
WidgetDelegateView.

[sky, 2012-02-16 03:28:07]

On Wed, Feb 15, 2012 at 6:57 PM,  <ben@chromium.org> wrote:
>
>
http://codereview.chromium.org/9406031/diff/1/ui/views/widget/native_widget_a...
> File ui/views/widget/native_widget_aura.cc (right):
>
>
http://codereview.chromium.org/9406031/diff/1/ui/views/widget/native_widget_a...
> ui/views/widget/native_widget_aura.cc:768: return can_activate_ &&
> delegate_->CanActivate();
> I don't think this can work... did you test this?
>
> delegate_ is the Widget. You want the delegate_'s delegate... i.e. the
> WidgetDelegateView.

Surprisingly it does work. Here's why:

bool Widget::CanActivate() const {
  return widget_delegate_->CanActivate();
}

  -Scott

[Ben Goodger (Google), 2012-02-16 03:31:30]

Heh, didn't know that was there. LGTM.

On Wed, Feb 15, 2012 at 7:28 PM, Scott Violet <sky@chromium.org> wrote:

> On Wed, Feb 15, 2012 at 6:57 PM,  <ben@chromium.org> wrote:
> >
> >
>
http://codereview.chromium.org/9406031/diff/1/ui/views/widget/native_widget_a...
> > File ui/views/widget/native_widget_aura.cc (right):
> >
> >
>
http://codereview.chromium.org/9406031/diff/1/ui/views/widget/native_widget_a...
> > ui/views/widget/native_widget_aura.cc:768: return can_activate_ &&
> > delegate_->CanActivate();
> > I don't think this can work... did you test this?
> >
> > delegate_ is the Widget. You want the delegate_'s delegate... i.e. the
> > WidgetDelegateView.
>
> Surprisingly it does work. Here's why:
>
> bool Widget::CanActivate() const {
>  return widget_delegate_->CanActivate();
> }
>
>  -Scott
>

[commit-bot: I haz the power, 2012-02-16 04:42:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/9406031/1

[commit-bot: I haz the power, 2012-02-16 04:42:56]

Can't apply patch for file ash/launcher/launcher.cc.
While running patch -p1 --forward --force;
patching file ash/launcher/launcher.cc
Hunk #1 FAILED at 4.
Hunk #2 succeeded at 19 (offset 1 line).
Hunk #3 succeeded at 57 (offset 2 lines).
Hunk #4 succeeded at 73 (offset 2 lines).
Hunk #5 succeeded at 97 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file ash/launcher/launcher.cc.rej