Issue 9406030: More slash fixes for Windows ninja, and some work on actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9406030: More slash fixes for Windows ninja, and some work on actions. (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
Evan Martin

CC:
gyp-developer_googlegroups.com, Nico

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

More slash fixes for Windows ninja, and some work on actions. Requires a fix to MakeDirs in ninja on Windows here: https://github.com/sgraham/ninja/commit/3aa8f906fe65187c6062c863c438c66818b20691 which is only in the deplist branch currently (also required). 24 of ~52 tests fail now. Committed: https://code.google.com/p/gyp/source/detail?r=1205

Patch Set 1 #

Total comments: 1

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		6 chunks	+17 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottmg

The os.path.join(..., 'lib') might be slightly questionable on other platforms?

8 years, 10 months ago (2012-02-16 01:21:05 UTC) #1

Evan Martin

8 years, 10 months ago (2012-02-16 16:10:33 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/9406030/diff/1/pylib/gyp/generator/nin...
File pylib/gyp/generator/ninja.py (right):

https://chromiumcodereview.appspot.com/9406030/diff/1/pylib/gyp/generator/nin...
pylib/gyp/generator/ninja.py:953: # things work.
I think there's a gyp attribute related to whether cygwin is required for a
given attribute.  Grep for cygwin in *.gyp*.

Expand Messages | Collapse Messages