Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: content/browser/ssl/ssl_manager.cc

Issue 9406001: Factor out ResourceDispatcherHost dependent code around SSLManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase for retry Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/ssl/ssl_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/ssl/ssl_manager.cc
diff --git a/content/browser/ssl/ssl_manager.cc b/content/browser/ssl/ssl_manager.cc
index 0322de0d4d1ee1d279400e81963fc4b4ef84da35..4a044b024e938a523317c62c872d7963399b8302 100644
--- a/content/browser/ssl/ssl_manager.cc
+++ b/content/browser/ssl/ssl_manager.cc
@@ -33,25 +33,35 @@ using content::SSLStatus;
using content::WebContents;
// static
-void SSLManager::OnSSLCertificateError(net::URLRequest* request,
+void SSLManager::OnSSLCertificateError(SSLErrorHandler::Delegate* delegate,
+ const content::GlobalRequestID& id,
+ const ResourceType::Type resource_type,
+ const GURL& url,
+ int render_process_id,
+ int render_view_id,
const net::SSLInfo& ssl_info,
bool fatal) {
+ DCHECK(delegate);
DVLOG(1) << "OnSSLCertificateError() cert_error: "
<< net::MapCertStatusToNetError(ssl_info.cert_status)
- << " url: " << request->url().spec()
+ << " id: " << id.child_id << "," << id.request_id
+ << " resource_type: " << resource_type
+ << " url: " << url.spec()
+ << " render_process_id: " << render_process_id
+ << " render_view_id: " << render_view_id
<< " cert_status: " << std::hex << ssl_info.cert_status;
- const ResourceRequestInfoImpl* info =
- ResourceRequestInfoImpl::ForRequest(request);
-
// A certificate error occurred. Construct a SSLCertErrorHandler object and
// hand it over to the UI thread for processing.
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&SSLCertErrorHandler::Dispatch,
- new SSLCertErrorHandler(ResourceDispatcherHostImpl::Get(),
- request,
- info->GetResourceType(),
+ new SSLCertErrorHandler(delegate,
+ id,
+ resource_type,
+ url,
+ render_process_id,
+ render_view_id,
ssl_info,
fatal)));
}
« no previous file with comments | « content/browser/ssl/ssl_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698