Factor out ResourceDispatcherHost dependent code around SSLManager

content/browser/renderer_host/resource_dispatcher_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the browser side of the resource dispatcher, it receives requests
 // from the child process (i.e. [Renderer, Plugin, Worker]ProcessHost), and
 // dispatches them to URLRequests. It then forwards the messages from the
 // URLRequests back to the correct process for handling.
 //
 // See http://dev.chromium.org/developers/design-documents/multi-process-resource-loading
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RESOURCE_DISPATCHER_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RESOURCE_DISPATCHER_HOST_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "base/timer.h"
 #include "content/browser/download/download_resource_handler.h"
 #include "content/browser/renderer_host/resource_queue.h"
+#include "content/browser/ssl/ssl_error_handler.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/notification_types.h"
 #include "ipc/ipc_message.h"
 #include "net/url_request/url_request.h"
 #include "webkit/glue/resource_type.h"
 
 class DownloadFileManager;
 class ResourceDispatcherHostRequestInfo;
 class ResourceHandler;
@@ skipping 12 matching lines @@
 
 namespace net {
 class CookieList;
 class URLRequestJobFactory;
 }  // namespace net
 
 namespace webkit_blob {
 class DeletableFileReference;
 }
 
-class CONTENT_EXPORT ResourceDispatcherHost : public net::URLRequest::Delegate {
+class CONTENT_EXPORT ResourceDispatcherHost
+    : public net::URLRequest::Delegate,
+      public SSLErrorHandler::Delegate {
  public:
   ResourceDispatcherHost();
   virtual ~ResourceDispatcherHost();
 
   // Returns the current ResourceDispatcherHost. May return NULL if it hasn't
   // been created yet.
   static ResourceDispatcherHost* Get();
 
   // Puts the resource dispatcher host in an inactive state (unable to begin
   // new requests).  Cancels all pending requests.
@@ skipping 141 matching lines @@
   // such IDs associated with the request (such as non-page-related requests),
   // this function will return false and both out params will be -1.
   static bool RenderViewForRequest(const net::URLRequest* request,
                                    int* render_process_host_id,
                                    int* render_view_host_id);
 
   // Retrieves a net::URLRequest.  Must be called from the IO thread.
   net::URLRequest* GetURLRequest(
       const content::GlobalRequestID& request_id) const;
 
+  // Retrieves a net::URLRequest.  Must be called from the IO thread.
+  net::URLRequest* GetURLRequest(
+      const SSLErrorHandler::instance_id& id) const;

[wtc, 2012/02/22 00:36:23]

It seems that this new method can be private.

This is function overloading.  Please make sure this case is
allowed by the Style Guide:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Overl...

or rename this function to describe its argument
(e.g., GetURLRequestFromSSLErrorHandler).

[Takashi Toyoshima, 2012/02/22 08:15:35]

I can remove this function now, because I decide to stick using
content::GlobalRequestID as a unique ID.

+
   void RemovePendingRequest(int child_id, int request_id);
 
   // Causes all new requests for the route identified by
   // |child_id| and |route_id| to be blocked (not being
   // started) until ResumeBlockedRequestsForRoute or
   // CancelBlockedRequestsForRoute is called.
   void BlockRequestsForRoute(int child_id, int route_id);
 
   // Resumes any blocked request for the specified route id.
   void ResumeBlockedRequestsForRoute(int child_id, int route_id);
@@ skipping 45 matching lines @@
 
   scoped_refptr<ResourceHandler> CreateResourceHandlerForDownload(
       net::URLRequest* request,
       content::ResourceContext* context,
       int child_id,
       int route_id,
       int request_id,
       const DownloadSaveInfo& save_info,
       const DownloadResourceHandler::OnStartedCallback& started_cb);
 
+  // SSLErrorHandler::Delegate
+  virtual ResourceType::Type ResourceTypeForInstance(
+      const SSLErrorHandler::instance_id& id) OVERRIDE;
+
+  virtual const GURL& URLForInstance(
+      const SSLErrorHandler::instance_id& id) OVERRIDE;
+
+  virtual bool RenderViewForInstance(const SSLErrorHandler::instance_id& id,
+                                     int* render_process_host_id,
+                                     int* render_view_host_id) OVERRIDE;
+
+  virtual void CancelRequestForInstance(const SSLErrorHandler::instance_id& id,
+                                        int error,
+                                        const net::SSLInfo* ssl_info) OVERRIDE;
+
+  virtual void ContinueRequestForInstance(
+      const SSLErrorHandler::instance_id& id) OVERRIDE;
+
  private:
   FRIEND_TEST_ALL_PREFIXES(ResourceDispatcherHostTest,
                            TestBlockedRequestsProcessDies);
   FRIEND_TEST_ALL_PREFIXES(ResourceDispatcherHostTest,
                            IncrementOutstandingRequestsMemoryCost);
   FRIEND_TEST_ALL_PREFIXES(ResourceDispatcherHostTest,
                            CalculateApproximateMemoryCost);
 
   class ShutdownTask;
 
@@ skipping 240 matching lines @@
   // Maps the request ID of request that is being transferred to a new RVH
   // to the respective request.
   typedef std::map<content::GlobalRequestID, net::URLRequest*>
       TransferredNavigations;
   TransferredNavigations transferred_navigations_;
 
   DISALLOW_COPY_AND_ASSIGN(ResourceDispatcherHost);
 };
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RESOURCE_DISPATCHER_HOST_H_