Update the registration protobuf and the test dm server.

Add the registration mode field to the protobuf.
Make the test dm server send the new register response.

BUG=chromium-os:26248
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123467

[pastarmovj, 2012-02-15 14:41:57]

@Mattias: Please review this CL.

@Bin: If we are good with that can you please make the server-side protobuf
change?

@Joao: FYI.

[Mattias Nissler (ping if slow), 2012-02-15 15:16:47]

http://codereview.chromium.org/9404006/diff/2001/chrome/browser/policy/proto/...
File chrome/browser/policy/proto/device_management_backend.proto (right):

http://codereview.chromium.org/9404006/diff/2001/chrome/browser/policy/proto/...
chrome/browser/policy/proto/device_management_backend.proto:62: enum DeviceMode
{
Should have comments explaining what that mode actually entails.

http://codereview.chromium.org/9404006/diff/2001/net/tools/testserver/device_...
File net/tools/testserver/device_management.py (right):

http://codereview.chromium.org/9404006/diff/2001/net/tools/testserver/device_...
net/tools/testserver/device_management.py:84: KIOSK_MACHINE_IDS = [  '100200300'
 ];
why not just make it KIOSK? That's much more obvious than your magic number :)

[pastarmovj, 2012-02-15 17:40:54]

All done.

http://codereview.chromium.org/9404006/diff/2001/chrome/browser/policy/proto/...
File chrome/browser/policy/proto/device_management_backend.proto (right):

http://codereview.chromium.org/9404006/diff/2001/chrome/browser/policy/proto/...
chrome/browser/policy/proto/device_management_backend.proto:62: enum DeviceMode
{
On 2012/02/15 15:16:47, Mattias Nissler wrote:
> Should have comments explaining what that mode actually entails.

Done.

http://codereview.chromium.org/9404006/diff/2001/net/tools/testserver/device_...
File net/tools/testserver/device_management.py (right):

http://codereview.chromium.org/9404006/diff/2001/net/tools/testserver/device_...
net/tools/testserver/device_management.py:84: KIOSK_MACHINE_IDS = [  '100200300'
 ];
On 2012/02/15 15:16:47, Mattias Nissler wrote:
> why not just make it KIOSK? That's much more obvious than your magic number :)

Done.

[pastarmovj, 2012-02-15 17:41:39]

On 2012/02/15 17:40:54, pastarmovj wrote:
> All done.
> 
>
http://codereview.chromium.org/9404006/diff/2001/chrome/browser/policy/proto/...
> File chrome/browser/policy/proto/device_management_backend.proto (right):
> 
>
http://codereview.chromium.org/9404006/diff/2001/chrome/browser/policy/proto/...
> chrome/browser/policy/proto/device_management_backend.proto:62: enum
DeviceMode
> {
> On 2012/02/15 15:16:47, Mattias Nissler wrote:
> > Should have comments explaining what that mode actually entails.
> 
> Done.
> 
>
http://codereview.chromium.org/9404006/diff/2001/net/tools/testserver/device_...
> File net/tools/testserver/device_management.py (right):
> 
>
http://codereview.chromium.org/9404006/diff/2001/net/tools/testserver/device_...
> net/tools/testserver/device_management.py:84: KIOSK_MACHINE_IDS = [ 
'100200300'
>  ];
> On 2012/02/15 15:16:47, Mattias Nissler wrote:
> > why not just make it KIOSK? That's much more obvious than your magic number
:)
> 
> Done.

BTW if you want i can split this CL in two - one for the proto and one for the
test server. Now that I think of it i don't know why I packed those together :)

[Mattias Nissler (ping if slow), 2012-02-16 10:39:01]

LGTM with a question.

http://codereview.chromium.org/9404006/diff/4/chrome/browser/policy/proto/dev...
File chrome/browser/policy/proto/device_management_backend.proto (right):

http://codereview.chromium.org/9404006/diff/4/chrome/browser/policy/proto/dev...
chrome/browser/policy/proto/device_management_backend.proto:72: optional
DeviceMode enrollment_type = 3 [default = ENTERPRISE];
If you declare a default, have you checked whether has_enrollment_type() returns
false if the field is not present?

[pastarmovj, 2012-02-16 14:55:21]

Checking the commit box.

http://codereview.chromium.org/9404006/diff/4/chrome/browser/policy/proto/dev...
File chrome/browser/policy/proto/device_management_backend.proto (right):

http://codereview.chromium.org/9404006/diff/4/chrome/browser/policy/proto/dev...
chrome/browser/policy/proto/device_management_backend.proto:72: optional
DeviceMode enrollment_type = 3 [default = ENTERPRISE];
On 2012/02/16 10:39:01, Mattias Nissler wrote:
> If you declare a default, have you checked whether has_enrollment_type()
returns
> false if the field is not present?

Yes. It returns false. The default however will ensure that calling
enrollment_type() even when has_enrollment_type() == false is returning sane
value.

[commit-bot: I haz the power, 2012-02-16 14:55:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/9404006/4

[commit-bot: I haz the power, 2012-02-16 14:55:59]

Presubmit check for 9404006-4 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/tools/testserver/device_management.py

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[pastarmovj, 2012-02-16 15:38:38]

@akalin: Can you please rubberstamp this CL. It only touches the device
management server we use to locally test enterprise code. 
Thanks :)

[akalin, 2012-02-17 02:05:06]

LGTM