Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7638)

Unified Diff: chrome/browser/ui/panels/panel_browsertest.cc

Issue 9403035: Refactor intra-strip panel drags by introducing PanelDragController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browsertest.cc
diff --git a/chrome/browser/ui/panels/panel_browsertest.cc b/chrome/browser/ui/panels/panel_browsertest.cc
index 041021d8c373cfec33f884bf1e97865da5f9d2a3..02ec2dc0602c03d46f64c929ee19ef38f9626857 100644
--- a/chrome/browser/ui/panels/panel_browsertest.cc
+++ b/chrome/browser/ui/panels/panel_browsertest.cc
@@ -770,7 +770,8 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DragThreePanels) {
IN_PROC_BROWSER_TEST_F(PanelBrowserTest, NotDraggable) {
Panel* panel = CreatePanel("panel");
- panel->set_draggable(false);
+ // This is used to simulate making a docked panel not draggable.
+ panel->set_has_temporary_layout(true);
Panel* panel2 = CreatePanel("panel2");
scoped_ptr<NativePanelTesting> panel_testing(
@@ -783,6 +784,8 @@ IN_PROC_BROWSER_TEST_F(PanelBrowserTest, NotDraggable) {
panel_testing->FinishDragTitlebar();
EXPECT_EQ(bounds.x(), panel->GetBounds().x());
+ // Reset the simulation hack so that the panel can be closed correctly.
+ panel->set_has_temporary_layout(false);
panel->Close();
panel2->Close();
}

Powered by Google App Engine
This is Rietveld 408576698