Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/browser/ui/panels/overflow_panel_strip.cc

Issue 9403035: Refactor intra-strip panel drags by introducing PanelDragController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix per feedback Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/overflow_panel_strip.cc
diff --git a/chrome/browser/ui/panels/overflow_panel_strip.cc b/chrome/browser/ui/panels/overflow_panel_strip.cc
index 446dcb0bd6b377e43e8c18f45ec2e670bf3f2bb3..b5b1e8e7e37c7ae67f3b98a52e0a7425384d7d2d 100644
--- a/chrome/browser/ui/panels/overflow_panel_strip.cc
+++ b/chrome/browser/ui/panels/overflow_panel_strip.cc
@@ -98,7 +98,6 @@ void OverflowPanelStrip::AddPanel(Panel* panel) {
// Set panel properties for this strip.
panel->SetAppIconVisibility(false);
- panel->set_draggable(false);
panel->ApplyVisualStyleForStrip();
if (num_panels() == 1) {
@@ -182,6 +181,23 @@ void OverflowPanelStrip::RestorePanel(Panel* panel) {
docked_strip->RestorePanel(panel);
}
+bool OverflowPanelStrip::CanDragPanel(const Panel* panel) const {
+ // All overflow panels are not draggable.
+ return false;
+}
+
+void OverflowPanelStrip::StartDraggingPanel(Panel* panel) {
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::DragPanel(Panel* panel, int delta_x, int delta_y) {
+ NOTREACHED();
+}
+
+void OverflowPanelStrip::EndDraggingPanel(Panel* panel, bool cancelled) {
+ NOTREACHED();
+}
+
void OverflowPanelStrip::RefreshLayout() {
if (panels_.empty())
return;

Powered by Google App Engine
This is Rietveld 408576698