Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: src/ic-inl.h

Issue 9403009: Count ICs that have type information. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix confusing --trace-opt output Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/mark-compact.cc » ('j') | src/objects-inl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 // Convert target address to the code object. Code::GetCodeFromTargetAddress 72 // Convert target address to the code object. Code::GetCodeFromTargetAddress
73 // is safe for use during GC where the map might be marked. 73 // is safe for use during GC where the map might be marked.
74 Code* result = Code::GetCodeFromTargetAddress(target); 74 Code* result = Code::GetCodeFromTargetAddress(target);
75 ASSERT(result->is_inline_cache_stub()); 75 ASSERT(result->is_inline_cache_stub());
76 return result; 76 return result;
77 } 77 }
78 78
79 79
80 void IC::SetTargetAtAddress(Address address, Code* target) { 80 void IC::SetTargetAtAddress(Address address, Code* target) {
81 ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub()); 81 ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub());
82 Code* old_target = GetTargetAtAddress(address);
82 #ifdef DEBUG 83 #ifdef DEBUG
83 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark 84 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
84 // ICs as strict mode. The strict-ness of the IC must be preserved. 85 // ICs as strict mode. The strict-ness of the IC must be preserved.
85 Code* old_target = GetTargetAtAddress(address);
86 if (old_target->kind() == Code::STORE_IC || 86 if (old_target->kind() == Code::STORE_IC ||
87 old_target->kind() == Code::KEYED_STORE_IC) { 87 old_target->kind() == Code::KEYED_STORE_IC) {
88 ASSERT(Code::GetStrictMode(old_target->extra_ic_state()) == 88 ASSERT(Code::GetStrictMode(old_target->extra_ic_state()) ==
89 Code::GetStrictMode(target->extra_ic_state())); 89 Code::GetStrictMode(target->extra_ic_state()));
90 } 90 }
91 #endif 91 #endif
92 Assembler::set_target_address_at(address, target->instruction_start()); 92 Assembler::set_target_address_at(address, target->instruction_start());
93 target->GetHeap()->incremental_marking()->RecordCodeTargetPatch(address, 93 target->GetHeap()->incremental_marking()->RecordCodeTargetPatch(address,
94 target); 94 target);
95 PostPatching(); 95 PostPatching(address, target, old_target);
96 } 96 }
97 97
98 98
99 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 99 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object,
100 JSObject* holder) { 100 JSObject* holder) {
101 if (object->IsJSObject()) { 101 if (object->IsJSObject()) {
102 return GetCodeCacheForObject(JSObject::cast(object), holder); 102 return GetCodeCacheForObject(JSObject::cast(object), holder);
103 } 103 }
104 // If the object is a value, we use the prototype map for the cache. 104 // If the object is a value, we use the prototype map for the cache.
105 ASSERT(object->IsString() || object->IsNumber() || object->IsBoolean()); 105 ASSERT(object->IsString() || object->IsNumber() || object->IsBoolean());
(...skipping 21 matching lines...) Expand all
127 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) { 127 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) {
128 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype()); 128 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype());
129 ASSERT(map_owner->IsJSObject()); 129 ASSERT(map_owner->IsJSObject());
130 return JSObject::cast(map_owner); 130 return JSObject::cast(map_owner);
131 } 131 }
132 132
133 133
134 } } // namespace v8::internal 134 } } // namespace v8::internal
135 135
136 #endif // V8_IC_INL_H_ 136 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/mark-compact.cc » ('j') | src/objects-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698