Count ICs that have type information.

src/runtime-profiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 91 matching lines @@
 }
 
 
 void RuntimeProfiler::Optimize(JSFunction* function, const char* reason) {
   ASSERT(function->IsOptimizable());
   if (FLAG_trace_opt) {
     PrintF("[marking ");
     function->PrintName();
     PrintF(" 0x%" V8PRIxPTR, reinterpret_cast<intptr_t>(function->address()));
     PrintF(" for recompilation, reason: %s", reason);
+    int typeinfo = function->shared()->ic_typeinfo_count();
+    int total = function->shared()->ic_total_count();
+    PrintF(", ICs with typeinfo: %d/%d (%d%%)",

[Vyacheslav Egorov (Chromium), 2012/02/15 12:07:39]

I sense SIGFPE here for code objects without ICs.

[Jakob Kummerow, 2012/02/17 16:07:52]

Done.

+           typeinfo, total, (100*typeinfo/total));
     PrintF("]\n");
   }
 
   // The next call to the function will trigger optimization.
   function->MarkForLazyRecompilation();
 }
 
 
 void RuntimeProfiler::AttemptOnStackReplacement(JSFunction* function) {
   // See AlwaysFullCompiler (in compiler.cc) comment on why we need
@@ skipping 129 matching lines @@
     if (function->shared()->is_toplevel()
         && (frame_count > 1
             || function->shared()->SourceSize() > kMaxToplevelSourceSize)) {
       continue;
     }
 
     if (FLAG_watch_ic_patching) {
       int ticks = function->shared()->profiler_ticks();
 
       if (ticks >= kProfilerTicksBeforeOptimization) {
-        // If this particular function hasn't had any ICs patched for enough
-        // ticks, optimize it now.
-        Optimize(function, "hot and stable");
+        int ic_typeinfo = function->shared()->ic_typeinfo_count();

[Vyacheslav Egorov (Chromium), 2012/02/15 12:07:39]

I would rename ic_typeinfo_count into ic_with_typeinfo_count

[Jakob Kummerow, 2012/02/17 16:07:52]

Done.

+        int ic_total = function->shared()->ic_total_count();
+        int percentage = 100 * ic_typeinfo / ic_total;

[Vyacheslav Egorov (Chromium), 2012/02/15 12:07:39]

I sense SIGFPE here for code objects without ICs.

[Jakob Kummerow, 2012/02/17 16:07:52]

Done.

+        if (percentage >= FLAG_type_info_threshold) {
+          // If this particular function hasn't had any ICs patched for enough
+          // ticks, optimize it now.
+          Optimize(function, "hot and stable");
+        } else {
+          if (FLAG_trace_opt_verbose) {
+            PrintF("[not yet optimizing ");
+            function->PrintName();
+            PrintF(", not enough type info: %d/%d (%d%%)]\n",
+                   ic_typeinfo, ic_total, percentage);
+          }
+        }
       } else if (!any_ic_changed_ &&
           function->shared()->code()->instruction_size() < kMaxSizeEarlyOpt) {
         // If no IC was patched since the last tick and this function is very
         // small, optimistically optimize it now.
         Optimize(function, "small function");
       } else if (!code_generated_ &&
           !any_ic_changed_ &&
           total_code_generated_ > 0 &&
           total_code_generated_ < 2000) {
         // If no code was generated and no IC was patched since the last tick,
@@ skipping 156 matching lines @@
 
 bool RuntimeProfilerRateLimiter::SuspendIfNecessary() {
   if (!RuntimeProfiler::IsSomeIsolateInJS()) {
     return RuntimeProfiler::WaitForSomeIsolateToEnterJS();
   }
   return false;
 }
 
 
 } }  // namespace v8::internal