Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

Issue 9403006: Extensions: run "custom bindings" v8-extensions in content scripts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/chrome_v8_context_set_unittest.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc b/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc
index 54a24005ea58f5bc70a089039f73b15fcbe9d60a..e128862f1e13c5eddff860f2f07053b4b78e92d1 100644
--- a/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc
+++ b/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc
@@ -22,7 +22,7 @@ TEST(ChromeV8ContextSet, Lifecycle) {
WebKit::WebFrame* frame = reinterpret_cast<WebKit::WebFrame*>(1);
std::string extension_id = "00000000000000000000000000000000";
ChromeV8Context* context =
- new ChromeV8Context(v8_context, frame, extension_id);
+ new ChromeV8Context(v8_context, frame, extension_id, false);
Aaron Boodman 2012/02/16 00:17:13 Boolean flags stink for readability. Consider addi
not at google - send to devlin 2012/02/16 01:45:53 Done. I'm not sure it's entirely right though. In
Aaron Boodman 2012/02/16 02:01:53 That's a good point. I'm not sure if this is calle
context_set.Add(context);
EXPECT_EQ(1u, context_set.GetAll().count(context));

Powered by Google App Engine
This is Rietveld 408576698