chrome/renderer/extensions/chrome_v8_context_set_unittest.cc - Issue 9403006: Extensions: run "custom bindings" v8-extensions in content scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

Issue 9403006: Extensions: run "custom bindings" v8-extensions in content scripts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: final comments Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

diff --git a/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc b/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

index 54a24005ea58f5bc70a089039f73b15fcbe9d60a..2a46ef4e9ea6ffd171b382792f4ef0664c26ecf3 100644

--- a/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

+++ b/chrome/renderer/extensions/chrome_v8_context_set_unittest.cc

@@ -22,7 +22,8 @@ TEST(ChromeV8ContextSet, Lifecycle) {

WebKit::WebFrame* frame = reinterpret_cast<WebKit::WebFrame*>(1);

std::string extension_id = "00000000000000000000000000000000";

ChromeV8Context* context =

- new ChromeV8Context(v8_context, frame, extension_id);

+ new ChromeV8Context(

+ v8_context, frame, extension_id, ChromeV8Context::OTHER);

context_set.Add(context);

EXPECT_EQ(1u, context_set.GetAll().count(context));